search

bnb-chain / node-binary

Binaries for full nodes, light-weighted clients
178 stars 116 forks source link

Mintable True error with Ledger #45

Closed jpthor closed 5 years ago

jpthor commented 5 years ago

Ledger Bug

When setting "mintable=false" in the CLI using Ledger, the Ledger overrides this to "mintable=true".

I believe this is a bug in the node-binary and how it serialises the transaction before it sends it to the ledger, so the issue is raised here, not in the Ledger Repo.

Set up

Use the CLI to create a token issuance with mintable=false:

image

Use the ledger to send the transaction. The Ledger over-rides this, and sets it to true:

image

Workaround

Delete "--mintable false" from the CLI command and the ledger chooses the default, which is false and an asset can be issued that is mintable=false.

notatestuser commented 5 years ago

Thanks for the report! This one has been fixed in #44. (tl;dr: Use --mintable=false or omit the flag completely in your CLI invocation.)