bnb-chain / opbnb

MIT License
403 stars 163 forks source link

fix(op-node): l1 client chan stuck when closed in ELSync mode #241

Closed welkin22 closed 1 month ago

welkin22 commented 2 months ago

Description

Fixed the issue where the node might get stuck in the l1 client shutdown function when the node is in engine sync mode during shutdown.

Rationale

When the node has not yet fully synchronized and was in engine sync mode, the GoOrUpdatePreFetchReceipts method is not executed. At this time, the done channel of the l1 client has no consumers. If the node is closed at this moment, it will get stuck at the l1 client close operation. If I simply close the done channel, a panic: Log in goroutine after Test_xxx has completed issue will occur during e2e testing. I must ensure that the done channel is truly closed before the close method returns.

Example

none

Changes

Notable changes: