bnb-chain / revm

MIT License
12 stars 9 forks source link

fix: return empty bytes when bls validation failed #68

Closed pythonberg1997 closed 2 months ago

pythonberg1997 commented 2 months ago

Description

This pr is to fix an issue in BLS_SIGNATURE_VALIDATION precompile contract

Rationale

The function should return empty bytes rather than 0x00

Example

add an example CLI or API response...

Changes

Notable changes:

Potential Impacts

github-actions[bot] commented 2 months ago

Valgrind Results:

==6520== Cachegrind, a cache and branch-prediction profiler
==6520== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==6520== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==6520== Command: target/release/snailtracer
==6520== 
--6520-- warning: L3 cache found, using its data for the LL simulation.
Running snailtracer example!
elapsed: 1.80112177s
==6520== 
==6520== I   refs:      427,738,238
==6520== I1  misses:          3,169
==6520== LLi misses:          2,832
==6520== I1  miss rate:        0.00%
==6520== LLi miss rate:        0.00%
==6520== 
==6520== D   refs:      204,083,474  (132,274,349 rd   + 71,809,125 wr)
==6520== D1  misses:        340,695  (    200,734 rd   +    139,961 wr)
==6520== LLd misses:        137,639  (      4,347 rd   +    133,292 wr)
==6520== D1  miss rate:         0.2% (        0.2%     +        0.2%  )
==6520== LLd miss rate:         0.1% (        0.0%     +        0.2%  )
==6520== 
==6520== LL refs:           343,864  (    203,903 rd   +    139,961 wr)
==6520== LL misses:         140,471  (      7,179 rd   +    133,292 wr)
==6520== LL miss rate:          0.0% (        0.0%     +        0.2%  )