search

bnb-chain / tss-lib

Threshold Signature Scheme, for ECDSA and EDDSA
MIT License
790 stars 271 forks source link

thorchain gg20 #127

Closed froyobin closed 9 months ago

froyobin commented 3 years ago

@omershlo Hi Omer this is the code that we applied in our environment, please have a review, thanks.

omershlo commented 3 years ago

Awesome!

froyobin commented 3 years ago

Awesome!

once this pr is accepted, we have another patch that fix the missing keygen blame in unicast communication ( VSS share check failure blame), we removed the unicast in keygen(unicast make the blame impossilbe as you do not know whether sender or receiver is the lier) and adding the identifying abort in keygen for the VSS check failure.

ackratos commented 3 years ago

Hi @froyobin, I wonder whether your team get this PR audited by third party? If not, we would like to kick off a security review procedure

froyobin commented 3 years ago

Hi cong, we have not get this pr audited by any party. it would be great if you can have someone to audit the code.

On Sun, Jan 31, 2021 at 10:13 PM cong notifications@github.com wrote:

Hi @froyobin https://github.com/froyobin, I wonder whether your team get this PR audited by third party? If not, we would like to kick off a security review procedure

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/binance-chain/tss-lib/pull/127#issuecomment-770365313, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJNCMFJPNFU6L27ZSI5N63S4U3OVANCNFSM4VH4LCOQ .

-- Regards, Bin

ackratos commented 3 years ago

Hi cong, we have not get this pr audited by any party. it would be great if you can have someone to audit the code.

Thanks for your reply. We will!

iakisme commented 3 years ago

@froyobin: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
iakisme commented 3 years ago

@froyobin: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
iakisme commented 3 years ago

@froyobin: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
iakisme commented 3 years ago

@froyobin: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
iakisme commented 3 years ago

@froyobin: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
iakisme commented 3 years ago

@froyobin: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
iakisme commented 3 years ago

@froyobin: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
iakisme commented 3 years ago

@froyobin: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
iakisme commented 3 years ago

@froyobin: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
iakisme commented 3 years ago

@froyobin: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
iakisme commented 3 years ago

@froyobin: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
iakisme commented 3 years ago

@froyobin: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.