search

bnb-chain / tss-lib

Threshold Signature Scheme, for ECDSA and EDDSA
MIT License
815 stars 277 forks source link

EDDSA signing utils problem #178

Open Aseyed opened 2 years ago

Aseyed commented 2 years ago

In EDDSA signing in addExtendedElements function at utils.go file at line 97 you are using GeAdd function as an external function which is implemented as an internal in edwards25519 and when I run my code, I get an error. Also the agl/ed25519 package is no longer maintained and they said that in their GitHub repo. You also use this library github.com/decred/dcrd/dcrec/edwards/v2 in the code. I think you should choose one.

Aseyed commented 2 years ago

It was my bad i didn't see the replace in your go mod file. I don't know why it's not working correctly. I also add the replace in my go mod file and it works.

yycen commented 2 years ago

The ed25519 we use is out of date. We plan to update it, and we notice that the curve is also in standard library now. We will see if we can adapt to use it.

Aseyed commented 2 years ago

Thank you. Could you tell me what critical problems may happen in using the outdated version of ed25519?

yycen commented 2 years ago

The old library we use in the go.mod will generally cause no issue I assume, based on the commit history of the lib that mostly are enhancements. Still we plan to have an update to the newer lib.

Menniti commented 1 year ago

Hello Guys, I'm having the same issue, any workaround for now until this could get updated? @Aseyed or @yycen Have you guys fixed ? Could you share what you have done in more details ?

I have found this lib, that maybe could be used https://github.com/bnb-chain/edwards25519

Thanks

Aseyed commented 1 year ago

Hi @Menniti! The easy way is using this line in go.mod file in your project.