bnb-chain / tss-lib

Threshold Signature Scheme, for ECDSA and EDDSA
MIT License
790 stars 271 forks source link

[Audit] Discrepancy with the re-sharing protocol #60

Closed AnomalRoil closed 4 years ago

AnomalRoil commented 5 years ago

In round_1_old_step_1.go, the "big Xjs" are included in the commitments made using the Com() function, whereas in the specification itself, only commitments for the v_ij from the Feldman's VSS scheme are included.

Similarly, the use of X_j is omitted from the decommitment in NewCommitteeStep2 step 6, but unwrapped in the code and stored in round.temp.OldBigXj and round.temp.OldKs in round_4_new_step_2.go.

They both do not appear to be reused after that, and take no further part in the specification document.