remove unnecessary approve

[github-actions[bot]]

Methods

Symbol	Meaning
◯	Execution gas for this method does not include intrinsic gas overhead
△	Cost was non-zero but below the precision setting for the currency display (see options)

	Min	Max	Avg	Calls	usd avg
BNBPartyFactory
createParty(string,string)	5,645,882	5,827,096	5,772,391	6	16.61
setNonfungiblePositionManager(address,address)	27,476	69,001	55,159	3	0.16
setSwapRouter(address)	24,142	46,282	38,902	3	0.11
NonfungiblePositionManager
approve(address,uint256)	46,052	46,371	46,212	2	0.13
SwapRouter
exactInput((bytes,address,uint256,uint256,uint256))	109,727	240,811	197,116	3	0.57
multicall(bytes[])	-	-	153,516	2	0.44

Deployments

	Min	Max	Avg	Block %	usd avg
BNBPartyFactory	-	-	2,247,879	1.7 %	6.47
MockNonfungibleTokenPositionDescriptor	-	-	111,537	0.1 %	0.32
NonfungiblePositionManager	-	-	5,171,524	4 %	14.88
SwapRouter	-	-	2,201,090	1.7 %	6.33
UniswapV3Factory	-	-	5,437,109	4.2 %	15.65

Solidity and Network Config

Settings	Value
Solidity: version	0.8.24
Solidity: optimized	true
Solidity: runs	200
Solidity: viaIR	false
Block Limit	130,000,000
L1 Gas Price	5 gwei
Token Price	575.61 usd/bnb
Network	BINANCE
Toolchain	hardhat

[github-actions[bot]]

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results. Summary

• incorrect-equality (1 results) (Medium)
• reentrancy-no-eth (1 results) (Medium)
• uninitialized-local (2 results) (Medium)
• unused-return (5 results) (Medium)
• shadowing-local (2 results) (Low)
• reentrancy-benign (2 results) (Low)
• low-level-calls (1 results) (Informational)
• naming-convention (6 results) (Informational)
• unused-import (1 results) (Informational)

  incorrect-equality

  Impact: Medium Confidence: High

• [ ] ID-0 BNBPartyInternal._createFLP(address) uses a dangerous strict equality:
  • IERC20(tokenA).balanceOf(address(this)) == party.initialTokenAmount

https://github.com/bnb-party/BNBParty.Factory/blob/d5d57964efc0bacbc2313459ff781b1a97b3229f/contracts/BNBPartyInternal.sol#L8-L36

reentrancy-no-eth

Impact: Medium Confidence: Medium

• [ ] ID-1 Reentrancy in BNBPartyInternal._handleLiquidity(): External calls:
  • (amount0,amount1) = BNBPositionManager.decreaseLiquidity(INonfungiblePositionManager.DecreaseLiquidityParams({tokenId:lpToTokenId[msg.sender],liquidity:pool.liquidity(),amount0Min:0,amount1Min:0,deadline:block.timestamp}))
  • IERC20(token0).approve(address(positionManager),amount0)
  • IERC20(token1).approve(address(positionManager),amount1)
  • _createLP(positionManager,token0,token1,amount0,amount1,party.lpFee)
    • liquidityPool = liquidityManager.createAndInitializePoolIfNecessary(token0,token1,fee,party.sqrtPriceX96)
    • (lpToTokenId[liquidityPool],None,None,None) = liquidityManager.mint(INonfungiblePositionManager.MintParams({token0:token0,token1:token1,fee:fee,tickLower:party.tickLower,tickUpper:party.tickUpper,amount0Desired:amount0,amount1Desired:amount1,amount0Min:0,amount1Min:0,recipient:address(this),deadline:block.timestamp})) State variables written after the call(s):
  • _createLP(positionManager,token0,token1,amount0,amount1,party.lpFee)
    • (lpToTokenId[liquidityPool],None,None,None) = liquidityManager.mint(INonfungiblePositionManager.MintParams({token0:token0,token1:token1,fee:fee,tickLower:party.tickLower,tickUpper:party.tickUpper,amount0Desired:amount0,amount1Desired:amount1,amount0Min:0,amount1Min:0,recipient:address(this),deadline:block.timestamp})) BNBPartyState.lpToTokenId can be used in cross function reentrancies:
  • BNBPartyState.lpToTokenId

https://github.com/bnb-party/BNBParty.Factory/blob/d5d57964efc0bacbc2313459ff781b1a97b3229f/contracts/BNBPartyInternal.sol#L78-L98

uninitialized-local

Impact: Medium Confidence: Medium

• [ ] ID-2 BNBPartyInternal._createFLP(address).amount0 is a local variable never initialized

https://github.com/bnb-party/BNBParty.Factory/blob/d5d57964efc0bacbc2313459ff781b1a97b3229f/contracts/BNBPartyInternal.sol#L15

• [ ] ID-3 BNBPartyInternal._createFLP(address).amount1 is a local variable never initialized

https://github.com/bnb-party/BNBParty.Factory/blob/d5d57964efc0bacbc2313459ff781b1a97b3229f/contracts/BNBPartyInternal.sol#L16

unused-return

Impact: Medium Confidence: Medium

• [ ] ID-4 BNBPartyInternal._createFLP(address) ignores return value by IERC20(_token).approve(address(BNBPositionManager),party.initialTokenAmount)

https://github.com/bnb-party/BNBParty.Factory/blob/d5d57964efc0bacbc2313459ff781b1a97b3229f/contracts/BNBPartyInternal.sol#L8-L36

• [ ] ID-5 BNBPartyInternal._createLP(INonfungiblePositionManager,address,address,uint256,uint256,uint24) ignores return value by (lpToTokenId[liquidityPool],None,None,None) = liquidityManager.mint(INonfungiblePositionManager.MintParams({token0:token0,token1:token1,fee:fee,tickLower:party.tickLower,tickUpper:party.tickUpper,amount0Desired:amount0,amount1Desired:amount1,amount0Min:0,amount1Min:0,recipient:address(this),deadline:block.timestamp}))

https://github.com/bnb-party/BNBParty.Factory/blob/d5d57964efc0bacbc2313459ff781b1a97b3229f/contracts/BNBPartyInternal.sol#L38-L70

• [ ] ID-6 BNBPartyInternal._handleLiquidity() ignores return value by IERC20(token1).approve(address(positionManager),amount1)

https://github.com/bnb-party/BNBParty.Factory/blob/d5d57964efc0bacbc2313459ff781b1a97b3229f/contracts/BNBPartyInternal.sol#L78-L98

• [ ] ID-7 BNBPartyInternal._executeSwap(address) ignores return value by swapRouter.exactInput{value: amountIn}(params)

https://github.com/bnb-party/BNBParty.Factory/blob/d5d57964efc0bacbc2313459ff781b1a97b3229f/contracts/BNBPartyInternal.sol#L100-L119

• [ ] ID-8 BNBPartyInternal._handleLiquidity() ignores return value by IERC20(token0).approve(address(positionManager),amount0)

https://github.com/bnb-party/BNBParty.Factory/blob/d5d57964efc0bacbc2313459ff781b1a97b3229f/contracts/BNBPartyInternal.sol#L78-L98

shadowing-local

Impact: Low Confidence: High

• [ ] ID-9 ERC20Token.constructor(string,string,uint256).name shadows:
  • ERC20.name() (function)
  • IERC20Metadata.name() (function)

https://github.com/bnb-party/BNBParty.Factory/blob/d5d57964efc0bacbc2313459ff781b1a97b3229f/contracts/token/ERC20Token.sol#L9

• [ ] ID-10 ERC20Token.constructor(string,string,uint256).symbol shadows:
  • ERC20.symbol() (function)
  • IERC20Metadata.symbol() (function)

https://github.com/bnb-party/BNBParty.Factory/blob/d5d57964efc0bacbc2313459ff781b1a97b3229f/contracts/token/ERC20Token.sol#L10

reentrancy-benign

Impact: Low Confidence: Medium

• [ ] ID-11 Reentrancy in BNBPartyInternal._createLP(INonfungiblePositionManager,address,address,uint256,uint256,uint24): External calls:
  • liquidityPool = liquidityManager.createAndInitializePoolIfNecessary(token0,token1,fee,party.sqrtPriceX96)
  • (lpToTokenId[liquidityPool],None,None,None) = liquidityManager.mint(INonfungiblePositionManager.MintParams({token0:token0,token1:token1,fee:fee,tickLower:party.tickLower,tickUpper:party.tickUpper,amount0Desired:amount0,amount1Desired:amount1,amount0Min:0,amount1Min:0,recipient:address(this),deadline:block.timestamp})) State variables written after the call(s):
  • (lpToTokenId[liquidityPool],None,None,None) = liquidityManager.mint(INonfungiblePositionManager.MintParams({token0:token0,token1:token1,fee:fee,tickLower:party.tickLower,tickUpper:party.tickUpper,amount0Desired:amount0,amount1Desired:amount1,amount0Min:0,amount1Min:0,recipient:address(this),deadline:block.timestamp}))

https://github.com/bnb-party/BNBParty.Factory/blob/d5d57964efc0bacbc2313459ff781b1a97b3229f/contracts/BNBPartyInternal.sol#L38-L70

• [ ] ID-12 Reentrancy in BNBPartyInternal._createFLP(address): External calls:
  • IERC20(_token).approve(address(BNBPositionManager),party.initialTokenAmount)
  • liquidityPool = _createLP(BNBPositionManager,tokenA,tokenB,amount0,amount1,party.partyLpFee)
    • liquidityPool = liquidityManager.createAndInitializePoolIfNecessary(token0,token1,fee,party.sqrtPriceX96)
    • (lpToTokenId[liquidityPool],None,None,None) = liquidityManager.mint(INonfungiblePositionManager.MintParams({token0:token0,token1:token1,fee:fee,tickLower:party.tickLower,tickUpper:party.tickUpper,amount0Desired:amount0,amount1Desired:amount1,amount0Min:0,amount1Min:0,recipient:address(this),deadline:block.timestamp})) State variables written after the call(s):
  • isParty[liquidityPool] = true
  • liquidityPool = _createLP(BNBPositionManager,tokenA,tokenB,amount0,amount1,party.partyLpFee)
    • (lpToTokenId[liquidityPool],None,None,None) = liquidityManager.mint(INonfungiblePositionManager.MintParams({token0:token0,token1:token1,fee:fee,tickLower:party.tickLower,tickUpper:party.tickUpper,amount0Desired:amount0,amount1Desired:amount1,amount0Min:0,amount1Min:0,recipient:address(this),deadline:block.timestamp}))

https://github.com/bnb-party/BNBParty.Factory/blob/d5d57964efc0bacbc2313459ff781b1a97b3229f/contracts/BNBPartyInternal.sol#L8-L36

low-level-calls

Impact: Informational Confidence: High

• [ ] ID-13 Low level call in BNBPartyInternal._unwrapAndSendBNB(address):
  • (success,None) = recipient.call{value: party.bonusTargetReach}()

https://github.com/bnb-party/BNBParty.Factory/blob/d5d57964efc0bacbc2313459ff781b1a97b3229f/contracts/BNBPartyInternal.sol#L72-L76

naming-convention

Impact: Informational Confidence: High

• [ ] ID-14 Variable BNBPartyState.WBNB is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/d5d57964efc0bacbc2313459ff781b1a97b3229f/contracts/BNBPartyState.sol#L20

• [ ] ID-15 Parameter BNBPartyState.setNonfungiblePositionManager(INonfungiblePositionManager,INonfungiblePositionManager)._BNBPositionManager is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/d5d57964efc0bacbc2313459ff781b1a97b3229f/contracts/BNBPartyState.sol#L35

• [ ] ID-16 Variable BNBPartyState.BNBPositionManager is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/d5d57964efc0bacbc2313459ff781b1a97b3229f/contracts/BNBPartyState.sol#L12

• [ ] ID-17 Parameter BNBPartyState.setNonfungiblePositionManager(INonfungiblePositionManager,INonfungiblePositionManager)._positionManager is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/d5d57964efc0bacbc2313459ff781b1a97b3229f/contracts/BNBPartyState.sol#L36

• [ ] ID-18 Parameter BNBPartyState.setSwapRouter(ISwapRouter)._swapRouter is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/d5d57964efc0bacbc2313459ff781b1a97b3229f/contracts/BNBPartyState.sol#L47

• [ ] ID-19 Function INonfungiblePositionManager.WETH9() is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/d5d57964efc0bacbc2313459ff781b1a97b3229f/contracts/interfaces/INonfungiblePositionManager.sol#L184

unused-import

Impact: Informational Confidence: High

• [ ] ID-20 The following unused import(s) in contracts/BNBPartyInternal.sol should be removed: -import "./token/ERC20Token.sol"; (contracts/BNBPartyInternal.sol#4)