bnb-party / BNBParty.Factory

Smart contract manages Liquidity Pools and Token creation, enabling decentralized swaps and liquidity handling

MIT License

2 stars 0 forks source link

update deploy script #39

Closed YouStillAlive closed 2 months ago

github-actions[bot] commented 2 months ago

Methods

Symbol	Meaning
◯	Execution gas for this method does not include intrinsic gas overhead
△	Cost was non-zero but below the precision setting for the currency display (see options)

	Min	Max	Avg	Calls	usd avg
BNBPartyFactory
createParty(string,string)	5,668,441	5,849,801	5,726,379	19	3.31
joinParty(address,uint256)	130,488	5,622,186	3,800,019	9	2.20
leaveParty(address,uint256,uint256)	171,638	185,318	176,198	3	0.10
setNonfungiblePositionManager(address,address)	27,381	68,906	62,974	7	0.04
setSwapRouter(address)	24,097	46,237	43,074	7	0.02
withdrawFee()	-	-	31,770	2	0.02
withdrawPartyLPFee(address[])	-	-	173,853	1	0.10
NonfungiblePositionManager
approve(address,uint256)	46,052	46,383	46,273	3	0.03
SwapRouter
exactInput((bytes,address,uint256,uint256,uint256))	109,767	119,325	116,139	3	0.07
multicall(bytes[])	-	-	141,256	2	0.08

Deployments

	Min	Max	Avg	Block %	usd avg
BNBPartyFactory	-	-	2,993,400	2.3 %	1.73
MockNonfungibleTokenPositionDescriptor	-	-	111,537	0.1 %	0.06
NonfungiblePositionManager	5,171,512	5,171,524	5,171,518	4 %	2.99
SwapRouter	2,201,078	2,201,090	2,201,086	1.7 %	1.27
UniswapV3Factory	5,437,097	5,437,109	5,437,107	4.2 %	3.14

Solidity and Network Config

Settings	Value
Solidity: version	0.8.24
Solidity: optimized	true
Solidity: runs	200
Solidity: viaIR	false
Block Limit	130,000,000
L1 Gas Price	1 gwei
Token Price	577.87 usd/bnb
Network	BINANCE
Toolchain	hardhat

github-actions[bot] commented 2 months ago

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results. Summary

incorrect-equality (2 results) (Medium)
reentrancy-no-eth (1 results) (Medium)
uninitialized-local (2 results) (Medium)
unused-return (8 results) (Medium)
shadowing-local (2 results) (Low)
reentrancy-benign (3 results) (Low)
reentrancy-events (5 results) (Low)
assembly (1 results) (Informational)
low-level-calls (6 results) (Informational)
naming-convention (7 results) (Informational)
reentrancy-unlimited-gas (1 results) (Informational)
incorrect-equality

Impact: Medium Confidence: High
[ ] ID-0 BNBPartyState.withdrawFee() uses a dangerous strict equality:
- address(this).balance == 0

https://github.com/bnb-party/BNBParty.Factory/blob/15e12ba584ff4e01b9dd0a41ae2ed5690ffa87a9/contracts/BNBPartyState.sol#L62-L68

[ ] ID-1 BNBPartyInternal._createFLP(address) uses a dangerous strict equality:
- IERC20(tokenA).balanceOf(address(this)) == party.initialTokenAmount

https://github.com/bnb-party/BNBParty.Factory/blob/15e12ba584ff4e01b9dd0a41ae2ed5690ffa87a9/contracts/BNBPartyInternal.sol#L8-L33

reentrancy-no-eth

Impact: Medium Confidence: Medium

[ ] ID-2 Reentrancy in BNBPartyInternal._handleLiquidity(address): External calls:

https://github.com/bnb-party/BNBParty.Factory/blob/15e12ba584ff4e01b9dd0a41ae2ed5690ffa87a9/contracts/BNBPartyInternal.sol#L90-L131

uninitialized-local

Impact: Medium Confidence: Medium

[ ] ID-3 BNBPartyInternal._createFLP(address).amount0 is a local variable never initialized

https://github.com/bnb-party/BNBParty.Factory/blob/15e12ba584ff4e01b9dd0a41ae2ed5690ffa87a9/contracts/BNBPartyInternal.sol#L12

[ ] ID-4 BNBPartyInternal._createFLP(address).amount1 is a local variable never initialized

https://github.com/bnb-party/BNBParty.Factory/blob/15e12ba584ff4e01b9dd0a41ae2ed5690ffa87a9/contracts/BNBPartyInternal.sol#L13

unused-return

Impact: Medium Confidence: Medium

[ ] ID-5 BNBPartyInternal._handleLiquidity(address) ignores return value by BNBPositionManager.collect(INonfungiblePositionManager.CollectParams({tokenId:lpToTokenId[msg.sender],recipient:address(this),amount0Max:uint128(amount0),amount1Max:uint128(amount1)}))

https://github.com/bnb-party/BNBParty.Factory/blob/15e12ba584ff4e01b9dd0a41ae2ed5690ffa87a9/contracts/BNBPartyInternal.sol#L90-L131

[ ] ID-6 BNBPartyInternal._createLP(INonfungiblePositionManager,address,address,uint256,uint256,uint160,uint24) ignores return value by (lpToTokenId[liquidityPool],None,None,None) = liquidityManager.mint(INonfungiblePositionManager.MintParams({token0:token0,token1:token1,fee:fee,tickLower:party.tickLower,tickUpper:party.tickUpper,amount0Desired:amount0,amount1Desired:amount1,amount0Min:0,amount1Min:0,recipient:address(this),deadline:block.timestamp}))

https://github.com/bnb-party/BNBParty.Factory/blob/15e12ba584ff4e01b9dd0a41ae2ed5690ffa87a9/contracts/BNBPartyInternal.sol#L35-L68

[ ] ID-7 BNBPartyState._collectFee(address,INonfungiblePositionManager) ignores return value by manager.collect(INonfungiblePositionManager.CollectParams({tokenId:lpToTokenId[liquidityPool],recipient:msg.sender,amount0Max:type()(uint128).max,amount1Max:type()(uint128).max}))

https://github.com/bnb-party/BNBParty.Factory/blob/15e12ba584ff4e01b9dd0a41ae2ed5690ffa87a9/contracts/BNBPartyState.sol#L96-L111

[ ] ID-8 BNBPartyInternal._handleLiquidity(address) ignores return value by IERC20(token0).approve(address(positionManager),amount0)

https://github.com/bnb-party/BNBParty.Factory/blob/15e12ba584ff4e01b9dd0a41ae2ed5690ffa87a9/contracts/BNBPartyInternal.sol#L90-L131

[ ] ID-9 BNBPartyInternal._createFLP(address) ignores return value by IERC20(_token).approve(address(BNBPositionManager),party.initialTokenAmount)

https://github.com/bnb-party/BNBParty.Factory/blob/15e12ba584ff4e01b9dd0a41ae2ed5690ffa87a9/contracts/BNBPartyInternal.sol#L8-L33

[ ] ID-10 BNBPartyInternal._executeSwap(address,address,address,uint256,uint256) ignores return value by swapRouter.exactInput{value: value}(params)

https://github.com/bnb-party/BNBParty.Factory/blob/15e12ba584ff4e01b9dd0a41ae2ed5690ffa87a9/contracts/BNBPartyInternal.sol#L138-L155

[ ] ID-11 BNBPartyInternal._handleLiquidity(address) ignores return value by IERC20(token1).approve(address(positionManager),amount1)

https://github.com/bnb-party/BNBParty.Factory/blob/15e12ba584ff4e01b9dd0a41ae2ed5690ffa87a9/contracts/BNBPartyInternal.sol#L90-L131

[ ] ID-12 BNBPartyInternal._handleLiquidity(address) ignores return value by (sqrtPriceX96,None,None,None,None,None,None) = pool.slot0()

https://github.com/bnb-party/BNBParty.Factory/blob/15e12ba584ff4e01b9dd0a41ae2ed5690ffa87a9/contracts/BNBPartyInternal.sol#L90-L131

shadowing-local

Impact: Low Confidence: High

[ ] ID-13 ERC20Token.constructor(string,string,uint256).name shadows:
- ERC20.name() (function)
- IERC20Metadata.name() (function)

https://github.com/bnb-party/BNBParty.Factory/blob/15e12ba584ff4e01b9dd0a41ae2ed5690ffa87a9/contracts/token/ERC20Token.sol#L9

[ ] ID-14 ERC20Token.constructor(string,string,uint256).symbol shadows:
- ERC20.symbol() (function)
- IERC20Metadata.symbol() (function)

https://github.com/bnb-party/BNBParty.Factory/blob/15e12ba584ff4e01b9dd0a41ae2ed5690ffa87a9/contracts/token/ERC20Token.sol#L10

reentrancy-benign

Impact: Low Confidence: Medium

[ ] ID-15 Reentrancy in BNBPartyInternal._createFLP(address): External calls:

https://github.com/bnb-party/BNBParty.Factory/blob/15e12ba584ff4e01b9dd0a41ae2ed5690ffa87a9/contracts/BNBPartyInternal.sol#L8-L33

[ ] ID-16 Reentrancy in BNBPartyFactory.createParty(string,string): External calls:
- liquidityPool = _createFLP(address(newToken))
- lpToCreator[liquidityPool] = msg.sender

https://github.com/bnb-party/BNBParty.Factory/blob/15e12ba584ff4e01b9dd0a41ae2ed5690ffa87a9/contracts/BNBPartyFactory.sol#L20-L41

[ ] ID-17 Reentrancy in BNBPartyInternal._createLP(INonfungiblePositionManager,address,address,uint256,uint256,uint160,uint24): External calls:

https://github.com/bnb-party/BNBParty.Factory/blob/15e12ba584ff4e01b9dd0a41ae2ed5690ffa87a9/contracts/BNBPartyInternal.sol#L35-L68

reentrancy-events

Impact: Low Confidence: Medium

[ ] ID-18 Reentrancy in BNBPartyInternal._unwrapAndSendBNB(address,uint256): External calls:
- WBNB.withdraw(unwrapAmount)
- _transferBNB(recipient,party.bonusTargetReach)
  - (success,None) = recipient.call{value: amount}() External calls sending eth:
- _transferBNB(recipient,party.bonusTargetReach)
  - (success,None) = recipient.call{value: amount}() Event emitted after the call(s):
- TransferOutBNB(recipient,amount)
  - _transferBNB(recipient,party.bonusTargetReach)

https://github.com/bnb-party/BNBParty.Factory/blob/15e12ba584ff4e01b9dd0a41ae2ed5690ffa87a9/contracts/BNBPartyInternal.sol#L70-L79

[ ] ID-19 Reentrancy in BNBPartyInternal._unwrapAndSendBNB(address,uint256): External calls:
- WBNB.withdraw(unwrapAmount)
- _transferBNB(recipient,party.bonusTargetReach + party.bonusPartyCreator)
  - (success,None) = recipient.call{value: amount}() External calls sending eth:
- _transferBNB(recipient,party.bonusTargetReach + party.bonusPartyCreator)
  - (success,None) = recipient.call{value: amount}() Event emitted after the call(s):
- TransferOutBNB(recipient,amount)
  - _transferBNB(recipient,party.bonusTargetReach + party.bonusPartyCreator)

https://github.com/bnb-party/BNBParty.Factory/blob/15e12ba584ff4e01b9dd0a41ae2ed5690ffa87a9/contracts/BNBPartyInternal.sol#L70-L79

[ ] ID-20 Reentrancy in BNBPartyInternal._unwrapAndSendBNB(address,uint256): External calls:

https://github.com/bnb-party/BNBParty.Factory/blob/15e12ba584ff4e01b9dd0a41ae2ed5690ffa87a9/contracts/BNBPartyInternal.sol#L70-L79

[ ] ID-21 Reentrancy in BNBPartyInternal._transferBNB(address,uint256): External calls:
- (success,None) = recipient.call{value: amount}() Event emitted after the call(s):
- TransferOutBNB(recipient,amount)

https://github.com/bnb-party/BNBParty.Factory/blob/15e12ba584ff4e01b9dd0a41ae2ed5690ffa87a9/contracts/BNBPartyInternal.sol#L81-L88

[ ] ID-22 Reentrancy in BNBPartyInternal._handleLiquidity(address): External calls:

https://github.com/bnb-party/BNBParty.Factory/blob/15e12ba584ff4e01b9dd0a41ae2ed5690ffa87a9/contracts/BNBPartyInternal.sol#L90-L131

assembly

Impact: Informational Confidence: High

[ ] ID-23 Address._revert(bytes) uses assembly
- INLINE ASM

https://github.com/bnb-party/BNBParty.Factory/blob/15e12ba584ff4e01b9dd0a41ae2ed5690ffa87a9/node_modules/@openzeppelin/contracts/utils/Address.sol#L146-L158

low-level-calls

Impact: Informational Confidence: High

[ ] ID-24 Low level call in SafeERC20._callOptionalReturnBool(IERC20,bytes):
- (success,returndata) = address(token).call(data)

https://github.com/bnb-party/BNBParty.Factory/blob/15e12ba584ff4e01b9dd0a41ae2ed5690ffa87a9/node_modules/@openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol#L110-L117

[ ] ID-25 Low level call in Address.functionStaticCall(address,bytes):
- (success,returndata) = target.staticcall(data)

https://github.com/bnb-party/BNBParty.Factory/blob/15e12ba584ff4e01b9dd0a41ae2ed5690ffa87a9/node_modules/@openzeppelin/contracts/utils/Address.sol#L95-L98

[ ] ID-26 Low level call in Address.functionDelegateCall(address,bytes):
- (success,returndata) = target.delegatecall(data)

https://github.com/bnb-party/BNBParty.Factory/blob/15e12ba584ff4e01b9dd0a41ae2ed5690ffa87a9/node_modules/@openzeppelin/contracts/utils/Address.sol#L104-L107

[ ] ID-27 Low level call in Address.sendValue(address,uint256):
- (success,None) = recipient.call{value: amount}()

https://github.com/bnb-party/BNBParty.Factory/blob/15e12ba584ff4e01b9dd0a41ae2ed5690ffa87a9/node_modules/@openzeppelin/contracts/utils/Address.sol#L41-L50

[ ] ID-28 Low level call in Address.functionCallWithValue(address,bytes,uint256):
- (success,returndata) = target.call{value: value}(data)

https://github.com/bnb-party/BNBParty.Factory/blob/15e12ba584ff4e01b9dd0a41ae2ed5690ffa87a9/node_modules/@openzeppelin/contracts/utils/Address.sol#L83-L89

[ ] ID-29 Low level call in BNBPartyInternal._transferBNB(address,uint256):
- (success,None) = recipient.call{value: amount}()

https://github.com/bnb-party/BNBParty.Factory/blob/15e12ba584ff4e01b9dd0a41ae2ed5690ffa87a9/contracts/BNBPartyInternal.sol#L81-L88

naming-convention

Impact: Informational Confidence: High

[ ] ID-30 Variable BNBPartyState.WBNB is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/15e12ba584ff4e01b9dd0a41ae2ed5690ffa87a9/contracts/BNBPartyState.sol#L21

[ ] ID-31 Parameter BNBPartyState.setNonfungiblePositionManager(INonfungiblePositionManager,INonfungiblePositionManager)._BNBPositionManager is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/15e12ba584ff4e01b9dd0a41ae2ed5690ffa87a9/contracts/BNBPartyState.sol#L44

[ ] ID-32 Variable BNBPartyState.BNBPositionManager is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/15e12ba584ff4e01b9dd0a41ae2ed5690ffa87a9/contracts/BNBPartyState.sol#L12

[ ] ID-33 Parameter BNBPartyState.setNonfungiblePositionManager(INonfungiblePositionManager,INonfungiblePositionManager)._positionManager is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/15e12ba584ff4e01b9dd0a41ae2ed5690ffa87a9/contracts/BNBPartyState.sol#L45

[ ] ID-34 Parameter BNBPartyState.setSwapRouter(ISwapRouter)._swapRouter is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/15e12ba584ff4e01b9dd0a41ae2ed5690ffa87a9/contracts/BNBPartyState.sol#L54

[ ] ID-35 Function INonfungiblePositionManager.WETH9() is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/15e12ba584ff4e01b9dd0a41ae2ed5690ffa87a9/contracts/interfaces/INonfungiblePositionManager.sol#L184

[ ] ID-36 Function IERC20Permit.DOMAIN_SEPARATOR() is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/15e12ba584ff4e01b9dd0a41ae2ed5690ffa87a9/node_modules/@openzeppelin/contracts/token/ERC20/extensions/IERC20Permit.sol#L89

reentrancy-unlimited-gas

Impact: Informational Confidence: Medium

[ ] ID-37 Reentrancy in BNBPartyState.withdrawFee(): External calls:
- address(msg.sender).transfer(address(this).balance) Event emitted after the call(s):
- TransferOutBNB(msg.sender,address(this).balance)

https://github.com/bnb-party/BNBParty.Factory/blob/15e12ba584ff4e01b9dd0a41ae2ed5690ffa87a9/contracts/BNBPartyState.sol#L62-L68