tests refactor

[YouStillAlive]

closes #36

[github-actions[bot]]

Methods

Symbol	Meaning
◯	Execution gas for this method does not include intrinsic gas overhead
△	Cost was non-zero but below the precision setting for the currency display (see options)

	Min	Max	Avg	Calls	usd avg
BNBPartyFactory
createParty(string,string)	5,668,459	5,882,147	5,728,542	29	16.79
joinParty(address,uint256)	153,302	5,642,318	1,818,734	20	5.33
leaveParty(address,uint256,uint256)	174,469	191,569	180,169	3	0.53
setNonfungiblePositionManager(address,address)	27,399	68,928	66,158	15	0.19
setSwapRouter(address)	24,119	46,259	44,782	15	0.13
withdrawFee()	-	-	31,792	2	0.09
withdrawPartyLPFee(address[])	173,830	173,875	173,853	2	0.51
NonfungiblePositionManager
approve(address,uint256)	46,052	46,383	46,273	3	0.14
SwapRouter
exactInput((bytes,address,uint256,uint256,uint256))	132,707	142,139	138,995	3	0.41
multicall(bytes[])	-	-	160,866	2	0.47

Deployments

	Min	Max	Avg	Block %	usd avg
BNBPartyFactory	3,305,188	3,305,200	3,305,199	2.5 %	9.69
MockNonfungibleTokenPositionDescriptor	-	-	111,537	0.1 %	0.33
NonfungiblePositionManager	5,171,500	5,171,524	5,171,519	4 %	15.16
SwapRouter	2,201,078	2,201,090	2,201,088	1.7 %	6.45
UniswapV3Factory	5,437,097	5,437,109	5,437,108	4.2 %	15.93

Solidity and Network Config

Settings	Value
Solidity: version	0.8.24
Solidity: optimized	true
Solidity: runs	200
Solidity: viaIR	false
Block Limit	130,000,000
L1 Gas Price	5 gwei
Token Price	586.12 usd/bnb
Network	BINANCE
Toolchain	hardhat

[github-actions[bot]]

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results. Summary

• incorrect-equality (2 results) (Medium)
• reentrancy-no-eth (1 results) (Medium)
• uninitialized-local (2 results) (Medium)
• unused-return (9 results) (Medium)
• shadowing-local (2 results) (Low)
• reentrancy-benign (3 results) (Low)
• reentrancy-events (5 results) (Low)
• assembly (1 results) (Informational)
• low-level-calls (6 results) (Informational)
• naming-convention (7 results) (Informational)
• reentrancy-unlimited-gas (1 results) (Informational)

  incorrect-equality

  Impact: Medium Confidence: High

• [ ] ID-0 BNBPartyInternal._createFLP(address) uses a dangerous strict equality:
  • IERC20(tokenA).balanceOf(address(this)) == party.initialTokenAmount

https://github.com/bnb-party/BNBParty.Factory/blob/91611c8c9682690e9dfb2f7e1b6e9115cdf7ec8d/contracts/BNBPartyInternal.sol#L7-L32

• [ ] ID-1 BNBPartyState.withdrawFee() uses a dangerous strict equality:
  • address(this).balance == 0

https://github.com/bnb-party/BNBParty.Factory/blob/91611c8c9682690e9dfb2f7e1b6e9115cdf7ec8d/contracts/BNBPartyState.sol#L70-L76

reentrancy-no-eth

Impact: Medium Confidence: Medium

• [ ] ID-2 Reentrancy in BNBPartyInternal._handleLiquidity(address): External calls:
  • (amount0,amount1) = BNBPositionManager.decreaseLiquidity(INonfungiblePositionManager.DecreaseLiquidityParams({tokenId:lpToTokenId[msg.sender],liquidity:pool.liquidity(),amount0Min:0,amount1Min:0,deadline:block.timestamp}))
  • BNBPositionManager.collect(INonfungiblePositionManager.CollectParams({tokenId:lpToTokenId[msg.sender],recipient:address(this),amount0Max:uint128(amount0),amount1Max:uint128(amount1)}))
  • IERC20(token0).approve(address(positionManager),amount0)
  • IERC20(token1).approve(address(positionManager),amount1)
  • _createLP(positionManager,token0,token1,amount0,amount1,sqrtPriceX96,party.lpFee)
    • liquidityPool = liquidityManager.createAndInitializePoolIfNecessary(token0,token1,fee,sqrtPriceX96)
    • (lpToTokenId[liquidityPool],None,None,None) = liquidityManager.mint(INonfungiblePositionManager.MintParams({token0:token0,token1:token1,fee:fee,tickLower:party.tickLower,tickUpper:party.tickUpper,amount0Desired:amount0,amount1Desired:amount1,amount0Min:0,amount1Min:0,recipient:address(this),deadline:block.timestamp})) State variables written after the call(s):
  • _createLP(positionManager,token0,token1,amount0,amount1,sqrtPriceX96,party.lpFee)
    • (lpToTokenId[liquidityPool],None,None,None) = liquidityManager.mint(INonfungiblePositionManager.MintParams({token0:token0,token1:token1,fee:fee,tickLower:party.tickLower,tickUpper:party.tickUpper,amount0Desired:amount0,amount1Desired:amount1,amount0Min:0,amount1Min:0,recipient:address(this),deadline:block.timestamp})) BNBPartyState.lpToTokenId can be used in cross function reentrancies:
  • BNBPartyState._collectFee(address,INonfungiblePositionManager)
  • BNBPartyState.lpToTokenId

https://github.com/bnb-party/BNBParty.Factory/blob/91611c8c9682690e9dfb2f7e1b6e9115cdf7ec8d/contracts/BNBPartyInternal.sol#L89-L130

uninitialized-local

Impact: Medium Confidence: Medium

• [ ] ID-3 BNBPartyInternal._createFLP(address).amount0 is a local variable never initialized

https://github.com/bnb-party/BNBParty.Factory/blob/91611c8c9682690e9dfb2f7e1b6e9115cdf7ec8d/contracts/BNBPartyInternal.sol#L11

• [ ] ID-4 BNBPartyInternal._createFLP(address).amount1 is a local variable never initialized

https://github.com/bnb-party/BNBParty.Factory/blob/91611c8c9682690e9dfb2f7e1b6e9115cdf7ec8d/contracts/BNBPartyInternal.sol#L12

unused-return

Impact: Medium Confidence: Medium

• [ ] ID-5 BNBPartyInternal._createFLP(address) ignores return value by IERC20(_token).approve(address(BNBPositionManager),party.initialTokenAmount)

https://github.com/bnb-party/BNBParty.Factory/blob/91611c8c9682690e9dfb2f7e1b6e9115cdf7ec8d/contracts/BNBPartyInternal.sol#L7-L32

• [ ] ID-6 BNBPartyInternal._handleLiquidity(address) ignores return value by IERC20(token1).approve(address(positionManager),amount1)

https://github.com/bnb-party/BNBParty.Factory/blob/91611c8c9682690e9dfb2f7e1b6e9115cdf7ec8d/contracts/BNBPartyInternal.sol#L89-L130

• [ ] ID-7 BNBPartyInternal._handleLiquidity(address) ignores return value by IERC20(token0).approve(address(positionManager),amount0)

https://github.com/bnb-party/BNBParty.Factory/blob/91611c8c9682690e9dfb2f7e1b6e9115cdf7ec8d/contracts/BNBPartyInternal.sol#L89-L130

• [ ] ID-8 BNBPartyState._getFeeGrowthInsideLastX128(IUniswapV3Pool) ignores return value by (None,feeGrowthInside0LastX128,feeGrowthInside1LastX128,None,None) = pool.positions(keccak256(bytes)(abi.encodePacked(address(BNBPositionManager),party.tickLower,party.tickUpper)))

https://github.com/bnb-party/BNBParty.Factory/blob/91611c8c9682690e9dfb2f7e1b6e9115cdf7ec8d/contracts/BNBPartyState.sol#L114-L134

• [ ] ID-9 BNBPartyInternal._createLP(INonfungiblePositionManager,address,address,uint256,uint256,uint160,uint24) ignores return value by (lpToTokenId[liquidityPool],None,None,None) = liquidityManager.mint(INonfungiblePositionManager.MintParams({token0:token0,token1:token1,fee:fee,tickLower:party.tickLower,tickUpper:party.tickUpper,amount0Desired:amount0,amount1Desired:amount1,amount0Min:0,amount1Min:0,recipient:address(this),deadline:block.timestamp}))

https://github.com/bnb-party/BNBParty.Factory/blob/91611c8c9682690e9dfb2f7e1b6e9115cdf7ec8d/contracts/BNBPartyInternal.sol#L34-L67

• [ ] ID-10 BNBPartyInternal._executeSwap(address,address,address,uint256,uint256) ignores return value by swapRouter.exactInput{value: value}(params)

https://github.com/bnb-party/BNBParty.Factory/blob/91611c8c9682690e9dfb2f7e1b6e9115cdf7ec8d/contracts/BNBPartyInternal.sol#L137-L154

• [ ] ID-11 BNBPartyInternal._handleLiquidity(address) ignores return value by BNBPositionManager.collect(INonfungiblePositionManager.CollectParams({tokenId:lpToTokenId[msg.sender],recipient:address(this),amount0Max:uint128(amount0),amount1Max:uint128(amount1)}))

https://github.com/bnb-party/BNBParty.Factory/blob/91611c8c9682690e9dfb2f7e1b6e9115cdf7ec8d/contracts/BNBPartyInternal.sol#L89-L130

• [ ] ID-12 BNBPartyState._collectFee(address,INonfungiblePositionManager) ignores return value by manager.collect(INonfungiblePositionManager.CollectParams({tokenId:lpToTokenId[liquidityPool],recipient:msg.sender,amount0Max:type()(uint128).max,amount1Max:type()(uint128).max}))

https://github.com/bnb-party/BNBParty.Factory/blob/91611c8c9682690e9dfb2f7e1b6e9115cdf7ec8d/contracts/BNBPartyState.sol#L148-L163

• [ ] ID-13 BNBPartyInternal._handleLiquidity(address) ignores return value by (sqrtPriceX96,None,None,None,None,None,None) = pool.slot0()

https://github.com/bnb-party/BNBParty.Factory/blob/91611c8c9682690e9dfb2f7e1b6e9115cdf7ec8d/contracts/BNBPartyInternal.sol#L89-L130

shadowing-local

Impact: Low Confidence: High

• [ ] ID-14 ERC20Token.constructor(string,string,uint256).name shadows:
  • ERC20.name() (function)
  • IERC20Metadata.name() (function)

https://github.com/bnb-party/BNBParty.Factory/blob/91611c8c9682690e9dfb2f7e1b6e9115cdf7ec8d/contracts/token/ERC20Token.sol#L9

• [ ] ID-15 ERC20Token.constructor(string,string,uint256).symbol shadows:
  • ERC20.symbol() (function)
  • IERC20Metadata.symbol() (function)

https://github.com/bnb-party/BNBParty.Factory/blob/91611c8c9682690e9dfb2f7e1b6e9115cdf7ec8d/contracts/token/ERC20Token.sol#L10

reentrancy-benign

Impact: Low Confidence: Medium

• [ ] ID-16 Reentrancy in BNBPartyFactory.createParty(string,string): External calls:
  • liquidityPool = _createFLP(address(newToken))
    • liquidityPool = liquidityManager.createAndInitializePoolIfNecessary(token0,token1,fee,sqrtPriceX96)
    • (lpToTokenId[liquidityPool],None,None,None) = liquidityManager.mint(INonfungiblePositionManager.MintParams({token0:token0,token1:token1,fee:fee,tickLower:party.tickLower,tickUpper:party.tickUpper,amount0Desired:amount0,amount1Desired:amount1,amount0Min:0,amount1Min:0,recipient:address(this),deadline:block.timestamp}))
    • IERC20(_token).approve(address(BNBPositionManager),party.initialTokenAmount) State variables written after the call(s):
  • lpToCreator[liquidityPool] = msg.sender

https://github.com/bnb-party/BNBParty.Factory/blob/91611c8c9682690e9dfb2f7e1b6e9115cdf7ec8d/contracts/BNBPartyFactory.sol#L20-L41

• [ ] ID-17 Reentrancy in BNBPartyInternal._createFLP(address): External calls:
  • IERC20(_token).approve(address(BNBPositionManager),party.initialTokenAmount)
  • liquidityPool = _createLP(BNBPositionManager,tokenA,tokenB,amount0,amount1,sqrtPrice,party.partyLpFee)
    • liquidityPool = liquidityManager.createAndInitializePoolIfNecessary(token0,token1,fee,sqrtPriceX96)
    • (lpToTokenId[liquidityPool],None,None,None) = liquidityManager.mint(INonfungiblePositionManager.MintParams({token0:token0,token1:token1,fee:fee,tickLower:party.tickLower,tickUpper:party.tickUpper,amount0Desired:amount0,amount1Desired:amount1,amount0Min:0,amount1Min:0,recipient:address(this),deadline:block.timestamp})) State variables written after the call(s):
  • isParty[liquidityPool] = true
  • liquidityPool = _createLP(BNBPositionManager,tokenA,tokenB,amount0,amount1,sqrtPrice,party.partyLpFee)
    • (lpToTokenId[liquidityPool],None,None,None) = liquidityManager.mint(INonfungiblePositionManager.MintParams({token0:token0,token1:token1,fee:fee,tickLower:party.tickLower,tickUpper:party.tickUpper,amount0Desired:amount0,amount1Desired:amount1,amount0Min:0,amount1Min:0,recipient:address(this),deadline:block.timestamp}))

https://github.com/bnb-party/BNBParty.Factory/blob/91611c8c9682690e9dfb2f7e1b6e9115cdf7ec8d/contracts/BNBPartyInternal.sol#L7-L32

• [ ] ID-18 Reentrancy in BNBPartyInternal._createLP(INonfungiblePositionManager,address,address,uint256,uint256,uint160,uint24): External calls:
  • liquidityPool = liquidityManager.createAndInitializePoolIfNecessary(token0,token1,fee,sqrtPriceX96)
  • (lpToTokenId[liquidityPool],None,None,None) = liquidityManager.mint(INonfungiblePositionManager.MintParams({token0:token0,token1:token1,fee:fee,tickLower:party.tickLower,tickUpper:party.tickUpper,amount0Desired:amount0,amount1Desired:amount1,amount0Min:0,amount1Min:0,recipient:address(this),deadline:block.timestamp})) State variables written after the call(s):
  • (lpToTokenId[liquidityPool],None,None,None) = liquidityManager.mint(INonfungiblePositionManager.MintParams({token0:token0,token1:token1,fee:fee,tickLower:party.tickLower,tickUpper:party.tickUpper,amount0Desired:amount0,amount1Desired:amount1,amount0Min:0,amount1Min:0,recipient:address(this),deadline:block.timestamp}))

https://github.com/bnb-party/BNBParty.Factory/blob/91611c8c9682690e9dfb2f7e1b6e9115cdf7ec8d/contracts/BNBPartyInternal.sol#L34-L67

reentrancy-events

Impact: Low Confidence: Medium

• [ ] ID-19 Reentrancy in BNBPartyInternal._transferBNB(address,uint256): External calls:
  • (success,None) = recipient.call{value: amount}() Event emitted after the call(s):
  • TransferOutBNB(recipient,amount)

https://github.com/bnb-party/BNBParty.Factory/blob/91611c8c9682690e9dfb2f7e1b6e9115cdf7ec8d/contracts/BNBPartyInternal.sol#L80-L87

• [ ] ID-20 Reentrancy in BNBPartyInternal._handleLiquidity(address): External calls:
  • (amount0,amount1) = BNBPositionManager.decreaseLiquidity(INonfungiblePositionManager.DecreaseLiquidityParams({tokenId:lpToTokenId[msg.sender],liquidity:pool.liquidity(),amount0Min:0,amount1Min:0,deadline:block.timestamp}))
  • BNBPositionManager.collect(INonfungiblePositionManager.CollectParams({tokenId:lpToTokenId[msg.sender],recipient:address(this),amount0Max:uint128(amount0),amount1Max:uint128(amount1)}))
  • IERC20(token0).approve(address(positionManager),amount0)
  • IERC20(token1).approve(address(positionManager),amount1)
  • _createLP(positionManager,token0,token1,amount0,amount1,sqrtPriceX96,party.lpFee)
    • liquidityPool = liquidityManager.createAndInitializePoolIfNecessary(token0,token1,fee,sqrtPriceX96)
    • (lpToTokenId[liquidityPool],None,None,None) = liquidityManager.mint(INonfungiblePositionManager.MintParams({token0:token0,token1:token1,fee:fee,tickLower:party.tickLower,tickUpper:party.tickUpper,amount0Desired:amount0,amount1Desired:amount1,amount0Min:0,amount1Min:0,recipient:address(this),deadline:block.timestamp}))
  • _unwrapAndSendBNB(recipient,unwrapAmount)
    • (success,None) = recipient.call{value: amount}()
    • WBNB.withdraw(unwrapAmount) External calls sending eth:
  • _unwrapAndSendBNB(recipient,unwrapAmount)
    • (success,None) = recipient.call{value: amount}() Event emitted after the call(s):
  • TransferOutBNB(recipient,amount)
    • _unwrapAndSendBNB(recipient,unwrapAmount)

https://github.com/bnb-party/BNBParty.Factory/blob/91611c8c9682690e9dfb2f7e1b6e9115cdf7ec8d/contracts/BNBPartyInternal.sol#L89-L130

• [ ] ID-21 Reentrancy in BNBPartyInternal._unwrapAndSendBNB(address,uint256): External calls:
  • WBNB.withdraw(unwrapAmount)
  • _transferBNB(recipient,party.bonusTargetReach)
    • (success,None) = recipient.call{value: amount}() External calls sending eth:
  • _transferBNB(recipient,party.bonusTargetReach)
    • (success,None) = recipient.call{value: amount}() Event emitted after the call(s):
  • TransferOutBNB(recipient,amount)
    • _transferBNB(recipient,party.bonusTargetReach)

https://github.com/bnb-party/BNBParty.Factory/blob/91611c8c9682690e9dfb2f7e1b6e9115cdf7ec8d/contracts/BNBPartyInternal.sol#L69-L78

• [ ] ID-22 Reentrancy in BNBPartyInternal._unwrapAndSendBNB(address,uint256): External calls:
  • WBNB.withdraw(unwrapAmount)
  • _transferBNB(recipient,party.bonusTargetReach + party.bonusPartyCreator)
    • (success,None) = recipient.call{value: amount}() External calls sending eth:
  • _transferBNB(recipient,party.bonusTargetReach + party.bonusPartyCreator)
    • (success,None) = recipient.call{value: amount}() Event emitted after the call(s):
  • TransferOutBNB(recipient,amount)
    • _transferBNB(recipient,party.bonusTargetReach + party.bonusPartyCreator)

https://github.com/bnb-party/BNBParty.Factory/blob/91611c8c9682690e9dfb2f7e1b6e9115cdf7ec8d/contracts/BNBPartyInternal.sol#L69-L78

• [ ] ID-23 Reentrancy in BNBPartyInternal._unwrapAndSendBNB(address,uint256): External calls:
  • WBNB.withdraw(unwrapAmount)
  • _transferBNB(recipient,party.bonusTargetReach)
    • (success,None) = recipient.call{value: amount}()
  • _transferBNB(creator,party.bonusPartyCreator)
    • (success,None) = recipient.call{value: amount}() External calls sending eth:
  • _transferBNB(recipient,party.bonusTargetReach)
    • (success,None) = recipient.call{value: amount}()
  • _transferBNB(creator,party.bonusPartyCreator)
    • (success,None) = recipient.call{value: amount}() Event emitted after the call(s):
  • TransferOutBNB(recipient,amount)
    • _transferBNB(creator,party.bonusPartyCreator)

https://github.com/bnb-party/BNBParty.Factory/blob/91611c8c9682690e9dfb2f7e1b6e9115cdf7ec8d/contracts/BNBPartyInternal.sol#L69-L78

assembly

Impact: Informational Confidence: High

• [ ] ID-24 Address._revert(bytes) uses assembly
  • INLINE ASM

https://github.com/bnb-party/BNBParty.Factory/blob/91611c8c9682690e9dfb2f7e1b6e9115cdf7ec8d/node_modules/@openzeppelin/contracts/utils/Address.sol#L146-L158

low-level-calls

Impact: Informational Confidence: High

• [ ] ID-25 Low level call in SafeERC20._callOptionalReturnBool(IERC20,bytes):
  • (success,returndata) = address(token).call(data)

https://github.com/bnb-party/BNBParty.Factory/blob/91611c8c9682690e9dfb2f7e1b6e9115cdf7ec8d/node_modules/@openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol#L110-L117

• [ ] ID-26 Low level call in BNBPartyInternal._transferBNB(address,uint256):
  • (success,None) = recipient.call{value: amount}()

https://github.com/bnb-party/BNBParty.Factory/blob/91611c8c9682690e9dfb2f7e1b6e9115cdf7ec8d/contracts/BNBPartyInternal.sol#L80-L87

• [ ] ID-27 Low level call in Address.functionStaticCall(address,bytes):
  • (success,returndata) = target.staticcall(data)

https://github.com/bnb-party/BNBParty.Factory/blob/91611c8c9682690e9dfb2f7e1b6e9115cdf7ec8d/node_modules/@openzeppelin/contracts/utils/Address.sol#L95-L98

• [ ] ID-28 Low level call in Address.functionDelegateCall(address,bytes):
  • (success,returndata) = target.delegatecall(data)

https://github.com/bnb-party/BNBParty.Factory/blob/91611c8c9682690e9dfb2f7e1b6e9115cdf7ec8d/node_modules/@openzeppelin/contracts/utils/Address.sol#L104-L107

• [ ] ID-29 Low level call in Address.sendValue(address,uint256):
  • (success,None) = recipient.call{value: amount}()

https://github.com/bnb-party/BNBParty.Factory/blob/91611c8c9682690e9dfb2f7e1b6e9115cdf7ec8d/node_modules/@openzeppelin/contracts/utils/Address.sol#L41-L50

• [ ] ID-30 Low level call in Address.functionCallWithValue(address,bytes,uint256):
  • (success,returndata) = target.call{value: value}(data)

https://github.com/bnb-party/BNBParty.Factory/blob/91611c8c9682690e9dfb2f7e1b6e9115cdf7ec8d/node_modules/@openzeppelin/contracts/utils/Address.sol#L83-L89

naming-convention

Impact: Informational Confidence: High

• [ ] ID-31 Variable BNBPartyState.WBNB is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/91611c8c9682690e9dfb2f7e1b6e9115cdf7ec8d/contracts/BNBPartyState.sol#L22

• [ ] ID-32 Parameter BNBPartyState.setNonfungiblePositionManager(INonfungiblePositionManager,INonfungiblePositionManager)._BNBPositionManager is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/91611c8c9682690e9dfb2f7e1b6e9115cdf7ec8d/contracts/BNBPartyState.sol#L52

• [ ] ID-33 Variable BNBPartyState.BNBPositionManager is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/91611c8c9682690e9dfb2f7e1b6e9115cdf7ec8d/contracts/BNBPartyState.sol#L13

• [ ] ID-34 Parameter BNBPartyState.setNonfungiblePositionManager(INonfungiblePositionManager,INonfungiblePositionManager)._positionManager is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/91611c8c9682690e9dfb2f7e1b6e9115cdf7ec8d/contracts/BNBPartyState.sol#L53

• [ ] ID-35 Parameter BNBPartyState.setSwapRouter(ISwapRouter)._swapRouter is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/91611c8c9682690e9dfb2f7e1b6e9115cdf7ec8d/contracts/BNBPartyState.sol#L62

• [ ] ID-36 Function INonfungiblePositionManager.WETH9() is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/91611c8c9682690e9dfb2f7e1b6e9115cdf7ec8d/contracts/interfaces/INonfungiblePositionManager.sol#L184

• [ ] ID-37 Function IERC20Permit.DOMAIN_SEPARATOR() is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/91611c8c9682690e9dfb2f7e1b6e9115cdf7ec8d/node_modules/@openzeppelin/contracts/token/ERC20/extensions/IERC20Permit.sol#L89

reentrancy-unlimited-gas

Impact: Informational Confidence: Medium

• [ ] ID-38 Reentrancy in BNBPartyState.withdrawFee(): External calls:
  • address(msg.sender).transfer(address(this).balance) Event emitted after the call(s):
  • TransferOutBNB(msg.sender,address(this).balance)

https://github.com/bnb-party/BNBParty.Factory/blob/91611c8c9682690e9dfb2f7e1b6e9115cdf7ec8d/contracts/BNBPartyState.sol#L70-L76