bnb-party / BNBParty.Factory

Smart contract manages Liquidity Pools and Token creation, enabling decentralized swaps and liquidity handling

MIT License

2 stars 0 forks source link

curve tests #51

Closed YouStillAlive closed 1 month ago

github-actions[bot] commented 2 months ago

Methods

Symbol	Meaning
◯	Execution gas for this method does not include intrinsic gas overhead
△	Cost was non-zero but below the precision setting for the currency display (see options)

	Min	Max	Avg	Calls	usd avg
BNBPartyFactory
createParty(string,string)	5,728,876	5,904,124	5,763,684	36	2.89
joinParty(address,uint256)	143,982	5,707,644	2,076,919	26	1.04
leaveParty(address,uint256,uint256)	177,077	201,896	182,433	5	0.09
pause()	-	-	46,851	5	0.02
setBNBPartySwapRouter(address)	24,135	46,275	45,045	18	0.02
setNonfungiblePositionManager(address,address)	27,416	68,950	66,640	18	0.03
setSwapRouter(address)	-	-	46,298	16	0.02
unpause()	-	-	24,885	5	0.01
withdrawFee()	-	-	31,766	2	0.02
withdrawLPFee(address[])	-	-	173,634	1	0.09
withdrawPartyLPFee(address[])	-	-	173,814	2	0.09
NonfungiblePositionManager
approve(address,uint256)	46,052	46,395	46,303	4	0.02
SwapRouter
exactInput((bytes,address,uint256,uint256,uint256))	134,897	144,523	141,314	3	0.07
multicall(bytes[])	-	-	162,583	2	0.08

Deployments

	Min	Max	Avg	Block %	usd avg
BNBPartyFactory	3,709,974	3,709,986	3,709,985	2.9 %	1.86
MockContract	-	-	107,817	0.1 %	0.05
MockNonfungibleTokenPositionDescriptor	-	-	111,537	0.1 %	0.06
NonfungiblePositionManager	5,171,500	5,171,524	5,171,518	4 %	2.60
SqrtPriceCalculator	-	-	278,712	0.2 %	0.14
SwapRouter	2,201,066	2,201,090	2,201,085	1.7 %	1.11
UniswapV3Factory	5,437,097	5,437,109	5,437,108	4.2 %	2.73

Solidity and Network Config

Settings	Value
Solidity: version	0.8.24
Solidity: optimized	true
Solidity: runs	200
Solidity: viaIR	false
Block Limit	130,000,000
L1 Gas Price	1 gwei
Token Price	502.25 usd/bnb
Network	BINANCE
Toolchain	hardhat

github-actions[bot] commented 2 months ago

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results. Summary

reentrancy-no-eth (1 results) (Medium)
unused-return (6 results) (Medium)
reentrancy-benign (3 results) (Low)
reentrancy-events (4 results) (Low)
naming-convention (8 results) (Informational)
reentrancy-unlimited-gas (1 results) (Informational)
reentrancy-no-eth

Impact: Medium Confidence: Medium
[ ] ID-0 Reentrancy in BNBPartyLiquidity._handleLiquidity(address): External calls:

https://github.com/bnb-party/BNBParty.Factory/blob/e937dca937578032ac2efd080b26a430e2d6b3d4/contracts/BNBPartyLiquidity.sol#L14-L56

unused-return

Impact: Medium Confidence: Medium

[ ] ID-1 BNBPartyLiquidity._handleLiquidity(address) ignores return value by (sqrtPriceX96,None,None,None,None,None,None) = pool.slot0()

https://github.com/bnb-party/BNBParty.Factory/blob/e937dca937578032ac2efd080b26a430e2d6b3d4/contracts/BNBPartyLiquidity.sol#L14-L56

[ ] ID-2 BNBPartyCreation._createLP(INonfungiblePositionManager,address,address,uint256,uint256,uint160,uint24,IBNBPartyFactory.Ticks) ignores return value by (lpToTokenId[liquidityPool],None,None,None) = liquidityManager.mint(INonfungiblePositionManager.MintParams({token0:token0,token1:token1,fee:fee,tickLower:ticks.tickLower,tickUpper:ticks.tickUpper,amount0Desired:amount0,amount1Desired:amount1,amount0Min:0,amount1Min:0,recipient:address(this),deadline:block.timestamp}))

https://github.com/bnb-party/BNBParty.Factory/blob/e937dca937578032ac2efd080b26a430e2d6b3d4/contracts/BNBPartyCreation.sol#L45-L79

[ ] ID-3 BNBPartyFee._getFeeGrowthInsideLastX128(IUniswapV3Pool,bytes32) ignores return value by (None,feeGrowthInside0LastX128,feeGrowthInside1LastX128,None,None) = pool.positions(key)

https://github.com/bnb-party/BNBParty.Factory/blob/e937dca937578032ac2efd080b26a430e2d6b3d4/contracts/BNBPartyFee.sol#L68-L80

[ ] ID-4 BNBPartyLiquidityHelper._decreaseAndCollect(uint256,uint128) ignores return value by BNBPositionManager.collect(INonfungiblePositionManager.CollectParams({tokenId:tokenId,recipient:address(this),amount0Max:uint128(amount0),amount1Max:uint128(amount1)}))

https://github.com/bnb-party/BNBParty.Factory/blob/e937dca937578032ac2efd080b26a430e2d6b3d4/contracts/BNBPartyLiquidityHelper.sol#L16-L40

[ ] ID-5 BNBPartyManageable._collectFee(address,INonfungiblePositionManager) ignores return value by manager.collect(INonfungiblePositionManager.CollectParams({tokenId:lpToTokenId[liquidityPool],recipient:msg.sender,amount0Max:type()(uint128).max,amount1Max:type()(uint128).max}))

https://github.com/bnb-party/BNBParty.Factory/blob/e937dca937578032ac2efd080b26a430e2d6b3d4/contracts/BNBPartyManageable.sol#L93-L105

[ ] ID-6 BNBPartySwaps._executeSwap(ISwapRouter,ISwapRouter.ExactInputParams) ignores return value by ISwapRouter(router).exactInput{value: value}(params)

https://github.com/bnb-party/BNBParty.Factory/blob/e937dca937578032ac2efd080b26a430e2d6b3d4/contracts/BNBPartySwaps.sol#L47-L53

reentrancy-benign

Impact: Low Confidence: Medium

[ ] ID-7 Reentrancy in BNBPartyCreation._createLP(INonfungiblePositionManager,address,address,uint256,uint256,uint160,uint24,IBNBPartyFactory.Ticks): External calls:

https://github.com/bnb-party/BNBParty.Factory/blob/e937dca937578032ac2efd080b26a430e2d6b3d4/contracts/BNBPartyCreation.sol#L45-L79

[ ] ID-8 Reentrancy in BNBPartyCreation._createFLP(address): External calls:

https://github.com/bnb-party/BNBParty.Factory/blob/e937dca937578032ac2efd080b26a430e2d6b3d4/contracts/BNBPartyCreation.sol#L16-L33

[ ] ID-9 Reentrancy in BNBPartyLiquidity._handleLiquidity(address): External calls:

https://github.com/bnb-party/BNBParty.Factory/blob/e937dca937578032ac2efd080b26a430e2d6b3d4/contracts/BNBPartyLiquidity.sol#L14-L56

reentrancy-events

Impact: Low Confidence: Medium

[ ] ID-10 Reentrancy in BNBPartySwaps._unwrapAndSendBNB(address,uint256): External calls:
- WBNB.withdraw(unwrapAmount) External calls sending eth:
- _transferBNB(recipient,party.bonusTargetReach + party.bonusPartyCreator)
  - address(recipient).transfer(amount) Event emitted after the call(s):
- TransferOutBNB(recipient,amount)
  - _transferBNB(recipient,party.bonusTargetReach + party.bonusPartyCreator)

https://github.com/bnb-party/BNBParty.Factory/blob/e937dca937578032ac2efd080b26a430e2d6b3d4/contracts/BNBPartySwaps.sol#L13-L22

[ ] ID-11 Reentrancy in BNBPartySwaps._unwrapAndSendBNB(address,uint256): External calls:
- WBNB.withdraw(unwrapAmount) External calls sending eth:
- _transferBNB(recipient,party.bonusTargetReach)
  - address(recipient).transfer(amount) Event emitted after the call(s):
- TransferOutBNB(recipient,amount)
  - _transferBNB(recipient,party.bonusTargetReach)

https://github.com/bnb-party/BNBParty.Factory/blob/e937dca937578032ac2efd080b26a430e2d6b3d4/contracts/BNBPartySwaps.sol#L13-L22

[ ] ID-12 Reentrancy in BNBPartySwaps._unwrapAndSendBNB(address,uint256): External calls:
- WBNB.withdraw(unwrapAmount) External calls sending eth:
- _transferBNB(recipient,party.bonusTargetReach)
  - address(recipient).transfer(amount)
- _transferBNB(creator,party.bonusPartyCreator)
  - address(recipient).transfer(amount) Event emitted after the call(s):
- TransferOutBNB(recipient,amount)
  - _transferBNB(creator,party.bonusPartyCreator)

https://github.com/bnb-party/BNBParty.Factory/blob/e937dca937578032ac2efd080b26a430e2d6b3d4/contracts/BNBPartySwaps.sol#L13-L22

[ ] ID-13 Reentrancy in BNBPartyLiquidity._handleLiquidity(address): External calls:

https://github.com/bnb-party/BNBParty.Factory/blob/e937dca937578032ac2efd080b26a430e2d6b3d4/contracts/BNBPartyLiquidity.sol#L14-L56

naming-convention

Impact: Informational Confidence: High

[ ] ID-14 Variable BNBPartyState.WBNB is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/e937dca937578032ac2efd080b26a430e2d6b3d4/contracts/BNBPartyState.sol#L27

[ ] ID-15 Variable BNBPartyState.BNBPositionManager is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/e937dca937578032ac2efd080b26a430e2d6b3d4/contracts/BNBPartyState.sol#L14

[ ] ID-16 Parameter BNBPartyManageable.setSwapRouter(ISwapRouter)._swapRouter is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/e937dca937578032ac2efd080b26a430e2d6b3d4/contracts/BNBPartyManageable.sol#L35

[ ] ID-17 Parameter BNBPartyManageable.setNonfungiblePositionManager(INonfungiblePositionManager,INonfungiblePositionManager)._BNBPositionManager is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/e937dca937578032ac2efd080b26a430e2d6b3d4/contracts/BNBPartyManageable.sol#L15

[ ] ID-18 Function INonfungiblePositionManager.WETH9() is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/e937dca937578032ac2efd080b26a430e2d6b3d4/contracts/interfaces/INonfungiblePositionManager.sol#L184

[ ] ID-19 Parameter BNBPartyManageable.setNonfungiblePositionManager(INonfungiblePositionManager,INonfungiblePositionManager)._positionManager is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/e937dca937578032ac2efd080b26a430e2d6b3d4/contracts/BNBPartyManageable.sol#L16

[ ] ID-20 Parameter BNBPartyManageable.setBNBPartySwapRouter(ISwapRouter)._swapRouter is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/e937dca937578032ac2efd080b26a430e2d6b3d4/contracts/BNBPartyManageable.sol#L29

[ ] ID-21 Variable BNBPartyState.BNBSwapRouter is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/e937dca937578032ac2efd080b26a430e2d6b3d4/contracts/BNBPartyState.sol#L16

reentrancy-unlimited-gas

Impact: Informational Confidence: Medium

[ ] ID-22 Reentrancy in BNBPartySwaps._unwrapAndSendBNB(address,uint256): External calls:
- _transferBNB(recipient,party.bonusTargetReach)
  - address(recipient).transfer(amount)
- _transferBNB(creator,party.bonusPartyCreator)
  - address(recipient).transfer(amount) Event emitted after the call(s):
- TransferOutBNB(recipient,amount)
  - _transferBNB(creator,party.bonusPartyCreator)

https://github.com/bnb-party/BNBParty.Factory/blob/e937dca937578032ac2efd080b26a430e2d6b3d4/contracts/BNBPartySwaps.sol#L13-L22

codecov-commenter commented 2 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.