update deploy script

[github-actions[bot]]

Methods

Symbol	Meaning
◯	Execution gas for this method does not include intrinsic gas overhead
△	Cost was non-zero but below the precision setting for the currency display (see options)

	Min	Max	Avg	Calls	usd avg
BNBPartyFactory
createParty(string,string)	5,725,590	5,902,599	5,763,565	32	3.38
joinParty(address,uint256)	155,710	5,662,975	2,082,098	23	1.22
leaveParty(address,uint256,uint256)	176,031	200,171	181,349	5	0.11
setBNBPartySwapRouter(address)	24,180	46,320	44,843	15	0.03
setNonfungiblePositionManager(address,address)	27,399	68,928	66,159	15	0.04
setSwapRouter(address)	-	-	46,298	13	0.03
withdrawFee()	-	-	31,770	2	0.02
withdrawPartyLPFee(address[])	-	-	173,792	2	0.10
NonfungiblePositionManager
approve(address,uint256)	46,052	46,395	46,277	3	0.03
SwapRouter
exactInput((bytes,address,uint256,uint256,uint256))	133,951	143,509	140,323	3	0.08
multicall(bytes[])	-	-	160,532	2	0.09

Deployments

	Min	Max	Avg	Block %	usd avg
BNBPartyFactory	3,727,254	3,727,278	3,727,274	2.9 %	2.19
MockContract	-	-	107,817	0.1 %	0.06
MockNonfungibleTokenPositionDescriptor	-	-	111,537	0.1 %	0.07
NonfungiblePositionManager	5,171,512	5,171,524	5,171,518	4 %	3.03
SqrtPriceCalculator	-	-	278,712	0.2 %	0.16
SwapRouter	2,201,078	2,201,090	2,201,086	1.7 %	1.29
UniswapV3Factory	-	-	5,437,109	4.2 %	3.19

Solidity and Network Config

Settings	Value
Solidity: version	0.8.24
Solidity: optimized	true
Solidity: runs	200
Solidity: viaIR	false
Block Limit	130,000,000
L1 Gas Price	1 gwei
Token Price	586.59 usd/bnb
Network	BINANCE
Toolchain	hardhat

[github-actions[bot]]

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results. Summary

• incorrect-equality (2 results) (Medium)
• reentrancy-no-eth (1 results) (Medium)
• uninitialized-local (2 results) (Medium)
• unused-return (9 results) (Medium)
• shadowing-local (2 results) (Low)
• reentrancy-benign (4 results) (Low)
• reentrancy-events (5 results) (Low)
• assembly (1 results) (Informational)
• low-level-calls (6 results) (Informational)
• naming-convention (10 results) (Informational)
• reentrancy-unlimited-gas (1 results) (Informational)
• unused-import (1 results) (Informational)
• immutable-states (1 results) (Optimization)

  incorrect-equality

  Impact: Medium Confidence: High

• [ ] ID-0 BNBPartyLiquidity._createFLP(address) uses a dangerous strict equality:
  • IERC20(tokenA).balanceOf(address(this)) == party.initialTokenAmount

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/contracts/BNBPartyLiquidity.sol#L14-L39

• [ ] ID-1 BNBPartyManageable.withdrawFee() uses a dangerous strict equality:
  • address(this).balance == 0

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/contracts/BNBPartyManageable.sol#L41-L47

reentrancy-no-eth

Impact: Medium Confidence: Medium

• [ ] ID-2 Reentrancy in BNBPartyLiquidity._handleLiquidity(address): External calls:
  • (amount0,amount1) = BNBPositionManager.decreaseLiquidity(INonfungiblePositionManager.DecreaseLiquidityParams({tokenId:lpToTokenId[msg.sender],liquidity:liquidity,amount0Min:0,amount1Min:0,deadline:block.timestamp}))
  • BNBPositionManager.collect(INonfungiblePositionManager.CollectParams({tokenId:lpToTokenId[msg.sender],recipient:address(this),amount0Max:uint128(amount0),amount1Max:uint128(amount1)}))
  • IERC20(token0).approve(address(positionManager),amount0)
  • IERC20(token1).approve(address(positionManager),amount1)
  • _createLP(positionManager,token0,token1,amount0,amount1,newSqrtPriceX96,party.lpFee,party.lpTicks)
    • liquidityPool = liquidityManager.createAndInitializePoolIfNecessary(token0,token1,fee,sqrtPriceX96)
    • (lpToTokenId[liquidityPool],None,None,None) = liquidityManager.mint(INonfungiblePositionManager.MintParams({token0:token0,token1:token1,fee:fee,tickLower:ticks.tickLower,tickUpper:ticks.tickUpper,amount0Desired:amount0,amount1Desired:amount1,amount0Min:0,amount1Min:0,recipient:address(this),deadline:block.timestamp})) State variables written after the call(s):
  • _createLP(positionManager,token0,token1,amount0,amount1,newSqrtPriceX96,party.lpFee,party.lpTicks)
    • (lpToTokenId[liquidityPool],None,None,None) = liquidityManager.mint(INonfungiblePositionManager.MintParams({token0:token0,token1:token1,fee:fee,tickLower:ticks.tickLower,tickUpper:ticks.tickUpper,amount0Desired:amount0,amount1Desired:amount1,amount0Min:0,amount1Min:0,recipient:address(this),deadline:block.timestamp})) BNBPartyState.lpToTokenId can be used in cross function reentrancies:
  • BNBPartyState.lpToTokenId

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/contracts/BNBPartyLiquidity.sol#L90-L153

uninitialized-local

Impact: Medium Confidence: Medium

• [ ] ID-3 BNBPartyLiquidity._createFLP(address).amount1 is a local variable never initialized

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/contracts/BNBPartyLiquidity.sol#L17

• [ ] ID-4 BNBPartyLiquidity._createFLP(address).amount0 is a local variable never initialized

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/contracts/BNBPartyLiquidity.sol#L16

unused-return

Impact: Medium Confidence: Medium

• [ ] ID-5 BNBPartyView._getFeeGrowthInsideLastX128(IUniswapV3Pool,bytes32) ignores return value by (None,feeGrowthInside0LastX128,feeGrowthInside1LastX128,None,None) = pool.positions(key)

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/contracts/BNBPartyView.sol#L113-L125

• [ ] ID-6 BNBPartyLiquidity._handleLiquidity(address) ignores return value by IERC20(token1).approve(address(positionManager),amount1)

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/contracts/BNBPartyLiquidity.sol#L90-L153

• [ ] ID-7 BNBPartyLiquidity._createLP(INonfungiblePositionManager,address,address,uint256,uint256,uint160,uint24,IBNBPartyFactory.Ticks) ignores return value by (lpToTokenId[liquidityPool],None,None,None) = liquidityManager.mint(INonfungiblePositionManager.MintParams({token0:token0,token1:token1,fee:fee,tickLower:ticks.tickLower,tickUpper:ticks.tickUpper,amount0Desired:amount0,amount1Desired:amount1,amount0Min:0,amount1Min:0,recipient:address(this),deadline:block.timestamp}))

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/contracts/BNBPartyLiquidity.sol#L51-L85

• [ ] ID-8 BNBPartyManageable._collectFee(address,INonfungiblePositionManager) ignores return value by manager.collect(INonfungiblePositionManager.CollectParams({tokenId:lpToTokenId[liquidityPool],recipient:msg.sender,amount0Max:type()(uint128).max,amount1Max:type()(uint128).max}))

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/contracts/BNBPartyManageable.sol#L83-L95

• [ ] ID-9 BNBPartyLiquidity._handleLiquidity(address) ignores return value by IERC20(token0).approve(address(positionManager),amount0)

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/contracts/BNBPartyLiquidity.sol#L90-L153

• [ ] ID-10 BNBPartyLiquidity._handleLiquidity(address) ignores return value by BNBPositionManager.collect(INonfungiblePositionManager.CollectParams({tokenId:lpToTokenId[msg.sender],recipient:address(this),amount0Max:uint128(amount0),amount1Max:uint128(amount1)}))

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/contracts/BNBPartyLiquidity.sol#L90-L153

• [ ] ID-11 BNBPartySwaps._executeSwap(ISwapRouter,ISwapRouter.ExactInputParams) ignores return value by ISwapRouter(router).exactInput{value: value}(params)

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/contracts/BNBPartySwaps.sol#L50-L56

• [ ] ID-12 BNBPartyLiquidity._handleLiquidity(address) ignores return value by (sqrtPriceX96,None,None,None,None,None,None) = pool.slot0()

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/contracts/BNBPartyLiquidity.sol#L90-L153

• [ ] ID-13 BNBPartyLiquidity._createFLP(address) ignores return value by IERC20(_token).approve(address(BNBPositionManager),party.initialTokenAmount)

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/contracts/BNBPartyLiquidity.sol#L14-L39

shadowing-local

Impact: Low Confidence: High

• [ ] ID-14 ERC20Token.constructor(string,string,uint256).name shadows:
  • ERC20.name() (function)
  • IERC20Metadata.name() (function)

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/contracts/token/ERC20Token.sol#L16

• [ ] ID-15 ERC20Token.constructor(string,string,uint256).symbol shadows:
  • ERC20.symbol() (function)
  • IERC20Metadata.symbol() (function)

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/contracts/token/ERC20Token.sol#L17

reentrancy-benign

Impact: Low Confidence: Medium

• [ ] ID-16 Reentrancy in BNBPartyFactory.createParty(string,string): External calls:
  • liquidityPool = _createFLP(address(newToken))
    • liquidityPool = liquidityManager.createAndInitializePoolIfNecessary(token0,token1,fee,sqrtPriceX96)
    • (lpToTokenId[liquidityPool],None,None,None) = liquidityManager.mint(INonfungiblePositionManager.MintParams({token0:token0,token1:token1,fee:fee,tickLower:ticks.tickLower,tickUpper:ticks.tickUpper,amount0Desired:amount0,amount1Desired:amount1,amount0Min:0,amount1Min:0,recipient:address(this),deadline:block.timestamp}))
    • IERC20(_token).approve(address(BNBPositionManager),party.initialTokenAmount) State variables written after the call(s):
  • lpToCreator[liquidityPool] = msg.sender

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/contracts/BNBPartyFactory.sol#L32-L53

• [ ] ID-17 Reentrancy in BNBPartyLiquidity._createFLP(address): External calls:
  • IERC20(_token).approve(address(BNBPositionManager),party.initialTokenAmount)
  • liquidityPool = _createLP(BNBPositionManager,tokenA,tokenB,amount0,amount1,sqrtPrice,party.partyLpFee,party.partyTicks)
    • liquidityPool = liquidityManager.createAndInitializePoolIfNecessary(token0,token1,fee,sqrtPriceX96)
    • (lpToTokenId[liquidityPool],None,None,None) = liquidityManager.mint(INonfungiblePositionManager.MintParams({token0:token0,token1:token1,fee:fee,tickLower:ticks.tickLower,tickUpper:ticks.tickUpper,amount0Desired:amount0,amount1Desired:amount1,amount0Min:0,amount1Min:0,recipient:address(this),deadline:block.timestamp})) State variables written after the call(s):
  • isParty[liquidityPool] = true
  • isTokenOnPartyLP[_token] = true
  • liquidityPool = _createLP(BNBPositionManager,tokenA,tokenB,amount0,amount1,sqrtPrice,party.partyLpFee,party.partyTicks)
    • (lpToTokenId[liquidityPool],None,None,None) = liquidityManager.mint(INonfungiblePositionManager.MintParams({token0:token0,token1:token1,fee:fee,tickLower:ticks.tickLower,tickUpper:ticks.tickUpper,amount0Desired:amount0,amount1Desired:amount1,amount0Min:0,amount1Min:0,recipient:address(this),deadline:block.timestamp}))

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/contracts/BNBPartyLiquidity.sol#L14-L39

• [ ] ID-18 Reentrancy in BNBPartyLiquidity._handleLiquidity(address): External calls:
  • (amount0,amount1) = BNBPositionManager.decreaseLiquidity(INonfungiblePositionManager.DecreaseLiquidityParams({tokenId:lpToTokenId[msg.sender],liquidity:liquidity,amount0Min:0,amount1Min:0,deadline:block.timestamp}))
  • BNBPositionManager.collect(INonfungiblePositionManager.CollectParams({tokenId:lpToTokenId[msg.sender],recipient:address(this),amount0Max:uint128(amount0),amount1Max:uint128(amount1)})) State variables written after the call(s):
  • isTokenOnPartyLP[token1] = false
  • isTokenOnPartyLP[token0] = false

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/contracts/BNBPartyLiquidity.sol#L90-L153

• [ ] ID-19 Reentrancy in BNBPartyLiquidity._createLP(INonfungiblePositionManager,address,address,uint256,uint256,uint160,uint24,IBNBPartyFactory.Ticks): External calls:
  • liquidityPool = liquidityManager.createAndInitializePoolIfNecessary(token0,token1,fee,sqrtPriceX96)
  • (lpToTokenId[liquidityPool],None,None,None) = liquidityManager.mint(INonfungiblePositionManager.MintParams({token0:token0,token1:token1,fee:fee,tickLower:ticks.tickLower,tickUpper:ticks.tickUpper,amount0Desired:amount0,amount1Desired:amount1,amount0Min:0,amount1Min:0,recipient:address(this),deadline:block.timestamp})) State variables written after the call(s):
  • (lpToTokenId[liquidityPool],None,None,None) = liquidityManager.mint(INonfungiblePositionManager.MintParams({token0:token0,token1:token1,fee:fee,tickLower:ticks.tickLower,tickUpper:ticks.tickUpper,amount0Desired:amount0,amount1Desired:amount1,amount0Min:0,amount1Min:0,recipient:address(this),deadline:block.timestamp}))

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/contracts/BNBPartyLiquidity.sol#L51-L85

reentrancy-events

Impact: Low Confidence: Medium

• [ ] ID-20 Reentrancy in BNBPartySwaps._unwrapAndSendBNB(address,uint256): External calls:
  • WBNB.withdraw(unwrapAmount)
  • _transferBNB(recipient,party.bonusTargetReach)
    • (success,None) = recipient.call{value: amount}()
  • _transferBNB(creator,party.bonusPartyCreator)
    • (success,None) = recipient.call{value: amount}() External calls sending eth:
  • _transferBNB(recipient,party.bonusTargetReach)
    • (success,None) = recipient.call{value: amount}()
  • _transferBNB(creator,party.bonusPartyCreator)
    • (success,None) = recipient.call{value: amount}() Event emitted after the call(s):
  • TransferOutBNB(recipient,amount)
    • _transferBNB(creator,party.bonusPartyCreator)

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/contracts/BNBPartySwaps.sol#L13-L22

• [ ] ID-21 Reentrancy in BNBPartySwaps._transferBNB(address,uint256): External calls:
  • (success,None) = recipient.call{value: amount}() Event emitted after the call(s):
  • TransferOutBNB(recipient,amount)

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/contracts/BNBPartySwaps.sol#L28-L34

• [ ] ID-22 Reentrancy in BNBPartySwaps._unwrapAndSendBNB(address,uint256): External calls:
  • WBNB.withdraw(unwrapAmount)
  • _transferBNB(recipient,party.bonusTargetReach + party.bonusPartyCreator)
    • (success,None) = recipient.call{value: amount}() External calls sending eth:
  • _transferBNB(recipient,party.bonusTargetReach + party.bonusPartyCreator)
    • (success,None) = recipient.call{value: amount}() Event emitted after the call(s):
  • TransferOutBNB(recipient,amount)
    • _transferBNB(recipient,party.bonusTargetReach + party.bonusPartyCreator)

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/contracts/BNBPartySwaps.sol#L13-L22

• [ ] ID-23 Reentrancy in BNBPartyLiquidity._handleLiquidity(address): External calls:
  • (amount0,amount1) = BNBPositionManager.decreaseLiquidity(INonfungiblePositionManager.DecreaseLiquidityParams({tokenId:lpToTokenId[msg.sender],liquidity:liquidity,amount0Min:0,amount1Min:0,deadline:block.timestamp}))
  • BNBPositionManager.collect(INonfungiblePositionManager.CollectParams({tokenId:lpToTokenId[msg.sender],recipient:address(this),amount0Max:uint128(amount0),amount1Max:uint128(amount1)}))
  • IERC20(token0).approve(address(positionManager),amount0)
  • IERC20(token1).approve(address(positionManager),amount1)
  • _createLP(positionManager,token0,token1,amount0,amount1,newSqrtPriceX96,party.lpFee,party.lpTicks)
    • liquidityPool = liquidityManager.createAndInitializePoolIfNecessary(token0,token1,fee,sqrtPriceX96)
    • (lpToTokenId[liquidityPool],None,None,None) = liquidityManager.mint(INonfungiblePositionManager.MintParams({token0:token0,token1:token1,fee:fee,tickLower:ticks.tickLower,tickUpper:ticks.tickUpper,amount0Desired:amount0,amount1Desired:amount1,amount0Min:0,amount1Min:0,recipient:address(this),deadline:block.timestamp}))
  • _unwrapAndSendBNB(recipient,unwrapAmount)
    • WBNB.withdraw(unwrapAmount)
    • (success,None) = recipient.call{value: amount}() External calls sending eth:
  • _unwrapAndSendBNB(recipient,unwrapAmount)
    • (success,None) = recipient.call{value: amount}() Event emitted after the call(s):
  • TransferOutBNB(recipient,amount)
    • _unwrapAndSendBNB(recipient,unwrapAmount)

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/contracts/BNBPartyLiquidity.sol#L90-L153

• [ ] ID-24 Reentrancy in BNBPartySwaps._unwrapAndSendBNB(address,uint256): External calls:
  • WBNB.withdraw(unwrapAmount)
  • _transferBNB(recipient,party.bonusTargetReach)
    • (success,None) = recipient.call{value: amount}() External calls sending eth:
  • _transferBNB(recipient,party.bonusTargetReach)
    • (success,None) = recipient.call{value: amount}() Event emitted after the call(s):
  • TransferOutBNB(recipient,amount)
    • _transferBNB(recipient,party.bonusTargetReach)

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/contracts/BNBPartySwaps.sol#L13-L22

assembly

Impact: Informational Confidence: High

• [ ] ID-25 Address._revert(bytes) uses assembly
  • INLINE ASM

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/node_modules/@openzeppelin/contracts/utils/Address.sol#L146-L158

low-level-calls

Impact: Informational Confidence: High

• [ ] ID-26 Low level call in SafeERC20._callOptionalReturnBool(IERC20,bytes):
  • (success,returndata) = address(token).call(data)

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/node_modules/@openzeppelin/contracts/token/ERC20/utils/SafeERC20.sol#L110-L117

• [ ] ID-27 Low level call in Address.functionStaticCall(address,bytes):
  • (success,returndata) = target.staticcall(data)

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/node_modules/@openzeppelin/contracts/utils/Address.sol#L95-L98

• [ ] ID-28 Low level call in Address.functionDelegateCall(address,bytes):
  • (success,returndata) = target.delegatecall(data)

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/node_modules/@openzeppelin/contracts/utils/Address.sol#L104-L107

• [ ] ID-29 Low level call in BNBPartySwaps._transferBNB(address,uint256):
  • (success,None) = recipient.call{value: amount}()

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/contracts/BNBPartySwaps.sol#L28-L34

• [ ] ID-30 Low level call in Address.sendValue(address,uint256):
  • (success,None) = recipient.call{value: amount}()

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/node_modules/@openzeppelin/contracts/utils/Address.sol#L41-L50

• [ ] ID-31 Low level call in Address.functionCallWithValue(address,bytes,uint256):
  • (success,returndata) = target.call{value: value}(data)

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/node_modules/@openzeppelin/contracts/utils/Address.sol#L83-L89

naming-convention

Impact: Informational Confidence: High

• [ ] ID-32 Variable BNBPartyState.WBNB is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/contracts/BNBPartyState.sol#L27

• [ ] ID-33 Variable BNBPartyState.BNBPositionManager is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/contracts/BNBPartyState.sol#L15

• [ ] ID-34 Parameter BNBPartyManageable.setSwapRouter(ISwapRouter)._swapRouter is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/contracts/BNBPartyManageable.sol#L34

• [ ] ID-35 Parameter BNBPartyManageable.setNonfungiblePositionManager(INonfungiblePositionManager,INonfungiblePositionManager)._BNBPositionManager is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/contracts/BNBPartyManageable.sol#L14

• [ ] ID-36 Function INonfungiblePositionManager.WETH9() is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/contracts/interfaces/INonfungiblePositionManager.sol#L184

• [ ] ID-37 Parameter BNBPartyManageable.setNonfungiblePositionManager(INonfungiblePositionManager,INonfungiblePositionManager)._positionManager is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/contracts/BNBPartyManageable.sol#L15

• [ ] ID-38 Function IERC20Permit.DOMAIN_SEPARATOR() is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/node_modules/@openzeppelin/contracts/token/ERC20/extensions/IERC20Permit.sol#L89

• [ ] ID-39 Parameter BNBPartyManageable.setBNBPartySwapRouter(ISwapRouter)._swapRouter is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/contracts/BNBPartyManageable.sol#L28

• [ ] ID-40 Modifier BNBPartyModifiers.SwapRouterAlreadySet(ISwapRouter,ISwapRouter) is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/contracts/BNBPartyModifiers.sol#L46-L54

• [ ] ID-41 Variable BNBPartyState.BNBSwapRouter is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/contracts/BNBPartyState.sol#L17

reentrancy-unlimited-gas

Impact: Informational Confidence: Medium

• [ ] ID-42 Reentrancy in BNBPartyManageable.withdrawFee(): External calls:
  • address(msg.sender).transfer(address(this).balance) Event emitted after the call(s):
  • TransferOutBNB(msg.sender,address(this).balance)

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/contracts/BNBPartyManageable.sol#L41-L47

unused-import

Impact: Informational Confidence: High

• [ ] ID-43 The following unused import(s) in contracts/BNBPartyState.sol should be removed: -import "./interfaces/IUniswapV3Pool.sol"; (contracts/BNBPartyState.sol#9)

immutable-states

Impact: Optimization Confidence: High

• [ ] ID-44 BNBPartyState.sqrtPriceCalculator should be immutable

https://github.com/bnb-party/BNBParty.Factory/blob/398beb2c04ac9773f03fa48dca761139a010f4db/contracts/BNBPartyState.sol#L23

[codecov-commenter]

:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.