bnb-party / BNBParty.Factory

Smart contract manages Liquidity Pools and Token creation, enabling decentralized swaps and liquidity handling

MIT License

2 stars 0 forks source link

fix `reentrancy-no-eth` slither warning #67

Closed YouStillAlive closed 1 month ago

github-actions[bot] commented 1 month ago

Methods

Symbol	Meaning
◯	Execution gas for this method does not include intrinsic gas overhead
△	Cost was non-zero but below the precision setting for the currency display (see options)

	Min	Max	Avg	Calls	usd avg
BNBPartyFactory
createParty(string,string)	5,728,901	5,905,663	5,764,366	36	15.74
joinParty(address,uint256)	143,964	5,709,444	2,080,549	26	5.68
leaveParty(address,uint256,uint256)	177,880	203,218	183,548	5	0.50
pause()	-	-	46,851	5	0.13
setBNBPartySwapRouter(address)	24,135	46,275	45,045	18	0.12
setNonfungiblePositionManager(address,address)	27,416	68,950	66,640	18	0.18
setSwapRouter(address)	-	-	46,298	16	0.13
unpause()	-	-	24,885	5	0.07
withdrawFee()	-	-	31,766	2	0.09
withdrawLPFee(address[])	-	-	173,618	1	0.47
withdrawPartyLPFee(address[])	-	-	173,798	2	0.47
NonfungiblePositionManager
approve(address,uint256)	46,052	46,395	46,303	4	0.13
SwapRouter
exactInput((bytes,address,uint256,uint256,uint256))	135,887	145,445	142,259	3	0.39
multicall(bytes[])	-	-	163,901	2	0.45

Deployments

	Min	Max	Avg	Block %	usd avg
BNBPartyFactory	3,704,885	3,704,897	3,704,896	2.8 %	10.12
MockContract	-	-	107,813	0.1 %	0.29
MockNonfungibleTokenPositionDescriptor	-	-	111,329	0.1 %	0.30
NonfungiblePositionManager	5,171,500	5,171,524	5,171,518	4 %	14.12
SqrtPriceCalculator	-	-	278,712	0.2 %	0.76
SwapRouter	2,201,066	2,201,090	2,201,085	1.7 %	6.01
UniswapV3Factory	5,437,097	5,437,109	5,437,108	4.2 %	14.85

Solidity and Network Config

Settings	Value
Solidity: version	0.8.26
Solidity: optimized	true
Solidity: runs	200
Solidity: viaIR	false
Block Limit	130,000,000
L1 Gas Price	5 gwei
Token Price	546.15 usd/bnb
Network	BINANCE
Toolchain	hardhat

codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines	Coverage Δ
contracts/BNBPartyCreation.sol	`100.00% <100.00%> (ø)`
contracts/BNBPartyFactory.sol	`100.00% <100.00%> (ø)`
contracts/BNBPartyLiquidity.sol	`100.00% <100.00%> (ø)`

github-actions[bot] commented 1 month ago

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results. Summary

unused-return (6 results) (Medium)
reentrancy-benign (1 results) (Low)
reentrancy-events (4 results) (Low)
naming-convention (8 results) (Informational)
reentrancy-unlimited-gas (1 results) (Informational)
unused-return

Impact: Medium Confidence: Medium
[ ] ID-0 BNBPartyLiquidity._handleLiquidity(address) ignores return value by (sqrtPriceX96,None,None,None,None,None,None) = pool.slot0()

https://github.com/bnb-party/BNBParty.Factory/blob/24fb39c8a0b45865ac0d5316facd669fa6702f87/contracts/BNBPartyLiquidity.sol#L14-L56

[ ] ID-1 BNBPartyLiquidityHelper._decreaseAndCollect(uint256,uint128) ignores return value by BNBPositionManager.collect(INonfungiblePositionManager.CollectParams({tokenId:tokenId,recipient:address(this),amount0Max:uint128(amount0),amount1Max:uint128(amount1)}))

https://github.com/bnb-party/BNBParty.Factory/blob/24fb39c8a0b45865ac0d5316facd669fa6702f87/contracts/BNBPartyLiquidityHelper.sol#L16-L40

[ ] ID-2 BNBPartyCreation._createLP(INonfungiblePositionManager,address,address,uint256,uint256,uint160,uint24,IBNBPartyFactory.Ticks) ignores return value by (tokenId,None,None,None) = liquidityManager.mint(INonfungiblePositionManager.MintParams({token0:token0,token1:token1,fee:fee,tickLower:ticks.tickLower,tickUpper:ticks.tickUpper,amount0Desired:amount0,amount1Desired:amount1,amount0Min:0,amount1Min:0,recipient:address(this),deadline:block.timestamp}))

https://github.com/bnb-party/BNBParty.Factory/blob/24fb39c8a0b45865ac0d5316facd669fa6702f87/contracts/BNBPartyCreation.sol#L43-L77

[ ] ID-3 BNBPartyManageable._collectFee(address,INonfungiblePositionManager) ignores return value by manager.collect(INonfungiblePositionManager.CollectParams({tokenId:lpToTokenId[liquidityPool],recipient:msg.sender,amount0Max:type()(uint128).max,amount1Max:type()(uint128).max}))

https://github.com/bnb-party/BNBParty.Factory/blob/24fb39c8a0b45865ac0d5316facd669fa6702f87/contracts/BNBPartyManageable.sol#L93-L105

[ ] ID-4 BNBPartySwaps._executeSwap(ISwapRouter,ISwapRouter.ExactInputParams) ignores return value by ISwapRouter(router).exactInput{value: value}(params)

https://github.com/bnb-party/BNBParty.Factory/blob/24fb39c8a0b45865ac0d5316facd669fa6702f87/contracts/BNBPartySwaps.sol#L47-L53

[ ] ID-5 BNBPartyFee._getFeeGrowthInsideLastX128(IUniswapV3Pool,bytes32) ignores return value by (None,feeGrowthInside0LastX128,feeGrowthInside1LastX128,None,None) = pool.positions(key)

https://github.com/bnb-party/BNBParty.Factory/blob/24fb39c8a0b45865ac0d5316facd669fa6702f87/contracts/BNBPartyFee.sol#L70-L82

reentrancy-benign

Impact: Low Confidence: Medium

[ ] ID-6 Reentrancy in BNBPartyLiquidity._handleLiquidity(address): External calls:

https://github.com/bnb-party/BNBParty.Factory/blob/24fb39c8a0b45865ac0d5316facd669fa6702f87/contracts/BNBPartyLiquidity.sol#L14-L56

reentrancy-events

Impact: Low Confidence: Medium

[ ] ID-7 Reentrancy in BNBPartySwaps._unwrapAndSendBNB(address,uint256): External calls:
- WBNB.withdraw(unwrapAmount) External calls sending eth:
- _transferBNB(recipient,party.bonusTargetReach + party.bonusPartyCreator)
  - address(recipient).transfer(amount) Event emitted after the call(s):
- TransferOutBNB(recipient,amount)
  - _transferBNB(recipient,party.bonusTargetReach + party.bonusPartyCreator)

https://github.com/bnb-party/BNBParty.Factory/blob/24fb39c8a0b45865ac0d5316facd669fa6702f87/contracts/BNBPartySwaps.sol#L13-L22

[ ] ID-8 Reentrancy in BNBPartySwaps._unwrapAndSendBNB(address,uint256): External calls:
- WBNB.withdraw(unwrapAmount) External calls sending eth:
- _transferBNB(recipient,party.bonusTargetReach)
  - address(recipient).transfer(amount) Event emitted after the call(s):
- TransferOutBNB(recipient,amount)
  - _transferBNB(recipient,party.bonusTargetReach)

https://github.com/bnb-party/BNBParty.Factory/blob/24fb39c8a0b45865ac0d5316facd669fa6702f87/contracts/BNBPartySwaps.sol#L13-L22

[ ] ID-9 Reentrancy in BNBPartySwaps._unwrapAndSendBNB(address,uint256): External calls:
- WBNB.withdraw(unwrapAmount) External calls sending eth:
- _transferBNB(recipient,party.bonusTargetReach)
  - address(recipient).transfer(amount)
- _transferBNB(creator,party.bonusPartyCreator)
  - address(recipient).transfer(amount) Event emitted after the call(s):
- TransferOutBNB(recipient,amount)
  - _transferBNB(creator,party.bonusPartyCreator)

https://github.com/bnb-party/BNBParty.Factory/blob/24fb39c8a0b45865ac0d5316facd669fa6702f87/contracts/BNBPartySwaps.sol#L13-L22

[ ] ID-10 Reentrancy in BNBPartyLiquidity._handleLiquidity(address): External calls:

https://github.com/bnb-party/BNBParty.Factory/blob/24fb39c8a0b45865ac0d5316facd669fa6702f87/contracts/BNBPartyLiquidity.sol#L14-L56

naming-convention

Impact: Informational Confidence: High

[ ] ID-11 Variable BNBPartyState.WBNB is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/24fb39c8a0b45865ac0d5316facd669fa6702f87/contracts/BNBPartyState.sol#L27

[ ] ID-12 Variable BNBPartyState.BNBPositionManager is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/24fb39c8a0b45865ac0d5316facd669fa6702f87/contracts/BNBPartyState.sol#L14

[ ] ID-13 Parameter BNBPartyManageable.setSwapRouter(ISwapRouter)._swapRouter is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/24fb39c8a0b45865ac0d5316facd669fa6702f87/contracts/BNBPartyManageable.sol#L35

[ ] ID-14 Parameter BNBPartyManageable.setNonfungiblePositionManager(INonfungiblePositionManager,INonfungiblePositionManager)._BNBPositionManager is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/24fb39c8a0b45865ac0d5316facd669fa6702f87/contracts/BNBPartyManageable.sol#L15

[ ] ID-15 Function INonfungiblePositionManager.WETH9() is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/24fb39c8a0b45865ac0d5316facd669fa6702f87/contracts/interfaces/INonfungiblePositionManager.sol#L184

[ ] ID-16 Parameter BNBPartyManageable.setNonfungiblePositionManager(INonfungiblePositionManager,INonfungiblePositionManager)._positionManager is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/24fb39c8a0b45865ac0d5316facd669fa6702f87/contracts/BNBPartyManageable.sol#L16

[ ] ID-17 Parameter BNBPartyManageable.setBNBPartySwapRouter(ISwapRouter)._swapRouter is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/24fb39c8a0b45865ac0d5316facd669fa6702f87/contracts/BNBPartyManageable.sol#L29

[ ] ID-18 Variable BNBPartyState.BNBSwapRouter is not in mixedCase

https://github.com/bnb-party/BNBParty.Factory/blob/24fb39c8a0b45865ac0d5316facd669fa6702f87/contracts/BNBPartyState.sol#L16

reentrancy-unlimited-gas

Impact: Informational Confidence: Medium

[ ] ID-19 Reentrancy in BNBPartySwaps._unwrapAndSendBNB(address,uint256): External calls:
- _transferBNB(recipient,party.bonusTargetReach)
  - address(recipient).transfer(amount)
- _transferBNB(creator,party.bonusPartyCreator)
  - address(recipient).transfer(amount) Event emitted after the call(s):
- TransferOutBNB(recipient,amount)
  - _transferBNB(creator,party.bonusPartyCreator)

https://github.com/bnb-party/BNBParty.Factory/blob/24fb39c8a0b45865ac0d5316facd669fa6702f87/contracts/BNBPartySwaps.sol#L13-L22