preparing for the party

[github-actions[bot]]

Methods

Symbol	Meaning
◯	Execution gas for this method does not include intrinsic gas overhead
△	Cost was non-zero but below the precision setting for the currency display (see options)

	Min	Max	Avg	Calls	usd avg

Deployments

	Min	Max	Avg	Block %	usd avg

Solidity and Network Config

Settings	Value
Solidity: version	0.8.24
Solidity: optimized	true
Solidity: runs	200
Solidity: viaIR	false
Block Limit	130,000,000
Gas Price	-
Token Price	-
Network	BINANCE
Toolchain	hardhat

[github-actions[bot]]

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results. Summary

• locked-ether (1 results) (Medium)
• shadowing-local (2 results) (Low)
• pragma (1 results) (Informational)
• solc-version (3 results) (Informational)
• naming-convention (2 results) (Informational)

  locked-ether

  Impact: Medium Confidence: High

• [ ] ID-0 Contract locking ether found: Contract BNBPartyFactory has payable functions:
  • IBNBParty.createToken(string,string)
  • BNBPartyFactory.createToken(string,string) But does not have a function to withdraw the ether

https://github.com/The-Poolz/BNBPartyFactory/blob/93bc1239c6d21f754f08688d9adb95bdfe10cbb5/contracts/BNBPartyFactory.sol#L8-L65

shadowing-local

Impact: Low Confidence: High

• [ ] ID-1 ERC20Token.constructor(string,string,uint256).name shadows:
  • ERC20.name() (function)
  • IERC20Metadata.name() (function)

https://github.com/The-Poolz/BNBPartyFactory/blob/93bc1239c6d21f754f08688d9adb95bdfe10cbb5/contracts/token/ERC20Token.sol#L9

• [ ] ID-2 ERC20Token.constructor(string,string,uint256).symbol shadows:
  • ERC20.symbol() (function)
  • IERC20Metadata.symbol() (function)

https://github.com/The-Poolz/BNBPartyFactory/blob/93bc1239c6d21f754f08688d9adb95bdfe10cbb5/contracts/token/ERC20Token.sol#L10

pragma

Impact: Informational Confidence: High

• [ ] ID-3 3 different versions of Solidity are used:
  • Version constraint ^0.8.20 is used by: -^0.8.20 -^0.8.20 -^0.8.20 -^0.8.20 -^0.8.20 -^0.8.20
  • Version constraint ^0.8.0 is used by: -^0.8.0 -^0.8.0 -^0.8.0
  • Version constraint >=0.7.5 is used by: ->=0.7.5 ->=0.7.5

https://github.com/The-Poolz/BNBPartyFactory/blob/93bc1239c6d21f754f08688d9adb95bdfe10cbb5/node_modules/@openzeppelin/contracts/interfaces/draft-IERC6093.sol#L3

solc-version

Impact: Informational Confidence: High

• [ ] ID-4 Version constraint ^0.8.0 contains known severe issues (https://solidity.readthedocs.io/en/latest/bugs.html)
  • FullInlinerNonExpressionSplitArgumentEvaluationOrder
  • MissingSideEffectsOnSelectorAccess
  • AbiReencodingHeadOverflowWithStaticArrayCleanup
  • DirtyBytesArrayToStorage
  • DataLocationChangeInInternalOverride
  • NestedCalldataArrayAbiReencodingSizeValidation
  • SignedImmutables
  • ABIDecodeTwoDimensionalArrayMemory
  • KeccakCaching. It is used by:
  • ^0.8.0
  • ^0.8.0
  • ^0.8.0

https://github.com/The-Poolz/BNBPartyFactory/blob/93bc1239c6d21f754f08688d9adb95bdfe10cbb5/contracts/BNBPartyFactory.sol#L2

• [ ] ID-5 Version constraint >=0.7.5 contains known severe issues (https://solidity.readthedocs.io/en/latest/bugs.html)
  • FullInlinerNonExpressionSplitArgumentEvaluationOrder
  • MissingSideEffectsOnSelectorAccess
  • AbiReencodingHeadOverflowWithStaticArrayCleanup
  • DirtyBytesArrayToStorage
  • DataLocationChangeInInternalOverride
  • NestedCalldataArrayAbiReencodingSizeValidation
  • SignedImmutables
  • ABIDecodeTwoDimensionalArrayMemory
  • KeccakCaching. It is used by:
  • >=0.7.5
  • >=0.7.5

https://github.com/The-Poolz/BNBPartyFactory/blob/93bc1239c6d21f754f08688d9adb95bdfe10cbb5/contracts/interfaces/INonfungiblePositionManager.sol#L2

• [ ] ID-6 Version constraint ^0.8.20 contains known severe issues (https://solidity.readthedocs.io/en/latest/bugs.html)
  • VerbatimInvalidDeduplication
  • FullInlinerNonExpressionSplitArgumentEvaluationOrder
  • MissingSideEffectsOnSelectorAccess. It is used by:
  • ^0.8.20
  • ^0.8.20
  • ^0.8.20
  • ^0.8.20
  • ^0.8.20
  • ^0.8.20

https://github.com/The-Poolz/BNBPartyFactory/blob/93bc1239c6d21f754f08688d9adb95bdfe10cbb5/node_modules/@openzeppelin/contracts/interfaces/draft-IERC6093.sol#L3

naming-convention

Impact: Informational Confidence: High

• [ ] ID-7 Function INonfungiblePositionManager.WETH9() is not in mixedCase

https://github.com/The-Poolz/BNBPartyFactory/blob/93bc1239c6d21f754f08688d9adb95bdfe10cbb5/contracts/interfaces/INonfungiblePositionManager.sol#L184

• [ ] ID-8 Variable BNBPartyFactory.BNBPositionManager is not in mixedCase

https://github.com/The-Poolz/BNBPartyFactory/blob/93bc1239c6d21f754f08688d9adb95bdfe10cbb5/contracts/BNBPartyFactory.sol#L9