bndkt / react-native-app-clip

Easily add an App Clip for iOS apps built with React Native
https://bndkt.com/blog/2022/react-native-app-clip
446 stars 19 forks source link

Remove Tablets or add a string to dynamically add it #19

Closed Fannolo closed 9 months ago

Fannolo commented 9 months ago

Summary

In my case, building the app with EAS causes some issues when the app doesn't explicitly support tablets, this is due to this line of code inside the library: https://github.com/bndkt/react-native-app-clip/blob/843f368d12cc604a50b5cfa74789f329775506d3/plugin/src/xcode/addXCConfigurationList.ts#L31

Removing it or applying a configuration inside the package could help to prevent this issue from happening

Fannolo commented 9 months ago

@bndkt I can add a PR if you want that can solve this issue

bndkt commented 9 months ago

@Fannolo thanks for flagging this. Turns out this line is not even required 😅 I just released a new version which removes it entirely.