bndkt / react-native-app-clip

Easily add an App Clip for iOS apps built with React Native
https://bndkt.com/blog/2022/react-native-app-clip
446 stars 19 forks source link

Build fails due to mismatch in Apple signin capabilities #23

Open nahn20 opened 9 months ago

nahn20 commented 9 months ago

Detection

This bug was extremely difficult to find, so I figured I'd add this section in case anyone is digging through all the closed issues like I was. I first encountered this bug while trying to build using this plugin EAS build. The Run fastlane step kept failing without a specific error message, besides DVTCoreDeviceEnabledState: DVTCoreDeviceEnabledState_Disabled set via user default (DVTEnableCoreDevice=disabled), which from past experience I don't believe is fatal.

I found the bug by following the Xcode build steps after which Xcode failed to run the app due to Communication with Apple failed. Before enabling Sign in with Apple for this app ID, enable Sign In with Apple for its parent app ID. and Provisioning profile "iOS Team Provision Profile: ~bundleId~.Clip" doesn't support the Sign in with Apple capability. Within the Signing & Capabilities tab, the Clip target included Sign in with Apple (not expected) while the main app did not (as expected).

Minimum Reproducible Example

Temporary Fix

Explicit false for appleSignIn in the plugin config.

Suggested Fix

Changing the default behavior might be a breaking change, but I think additional documentation here would be helpful for what the current default behavior is.