bndkt / react-native-app-clip

Easily add an App Clip for iOS apps built with React Native
https://bndkt.com/blog/2022/react-native-app-clip
492 stars 24 forks source link

Build fails due to mismatch in tablet configuration #24

Open nathan-ahn opened 1 year ago

nathan-ahn commented 1 year ago

Detection

EAS build failing due to error: The UIDeviceFamily of an App Clip ('[1]') must be equal to the UIDeviceFamily of its containing parent app ('[1, 2]').. After manually building and viewing in Xcode, the main app target supports iPhone, iPad, and Mac while the app clip supports only iPhone and Mac.

Minimum Reproducible Example

Temporary Fix

Remove tablet support from the main app (supportsTablet: false). For obvious reasons, not an ideal fix. I'm sure one could better fix this by manually adding tablet support in the app clip's Info.plist.

Suggested Fix

Conditionally add iPad as a supported destination based on the value of supportsTablet.

glburgess commented 3 weeks ago

Is there a way to make react-native-app-clip supportsTablet: true and not fail building?

The original app I'm trying to make a clip for supported tablets and Apple will not let an app drop support for tablets if it had supported it at one point so I cannot submit if supportsTablet is false and I cannot build if supportsTablet is true.

nathan-ahn commented 3 weeks ago

46 should fix this issue!