search

bndkt / react-native-app-clip

Easily add an App Clip for iOS apps built with React Native
https://bndkt.com/blog/2022/react-native-app-clip
504 stars 25 forks source link

Expo Updates, Info.plist and Compatibility #39

Open AlexandreFauchard opened 5 months ago

AlexandreFauchard commented 5 months ago

Hello @bndkt !

Thank you for your library, it helps me a lot ! It broke with Expo 51, so I forked it and added some features I needed (Expo updates, Info.plist customization, Android and web compatibility) If you would like to add my improvements to the main library, I would appreciate it.

calebpanza commented 5 months ago

Did you ever published the forked repo? Really interested in this!

iveshenry18 commented 2 months ago

This would be a great addition; especially being able to include arbitrary entries into the App Clip's Info.plist.

There's a typo in infoPlistAdditionnalEntries—should be infoPlistAdditionalEntries. I wonder if it'd be better to match the Expo convention and just call that parameter infoPlist?

@bndkt—any chance this or something similar could be merged any time soon?

iveshenry18 commented 2 months ago

I now see that the plugin applies any properties in your main expo -> ios -> infoPlist to the app clip's Info.plist. That was sufficient for my case.

nathan-ahn commented 4 days ago

Hey @AlexandreFauchard ! I'm helping Benedikt out with maintaining this repository. I love the changes! Would you mind splitting out this PR, specifically the EAS Updates support and infoPlistAdditionalEntries changes? I already have a planned fix for Android and web compatibility that I aim to have merged in this weekend, so no need to worry about that.

If you're busy, I'm also happy to split this up myself; just didn't want to steal your changes.