search

bndkt / react-native-app-clip

Easily add an App Clip for iOS apps built with React Native
https://bndkt.com/blog/2022/react-native-app-clip
499 stars 24 forks source link

EAS Build Failed #4

Closed mariomurrent-softwaresolutions closed 1 year ago

mariomurrent-softwaresolutions commented 2 years ago

The EAS Build is failing with the following error: Could not find target '....Clip' in project.pbxproj Do I need to eject the project in order to make the App Clip work?

I actually followed your instructions in the README, except for the prebuild step, because I haven't ejected the app.

bndkt commented 2 years ago

Hi, sorry for the delay I was traveling for a while. I just published a new version of the package (0.0.16). Please update to a new version and make sure that the app.json includes a "bundleIdentifier" value for iOS.

mariomurrent-softwaresolutions commented 2 years ago

Thx, the bundle identifier of the app is in the app.json but the build still fails.

Any ideas what I'm missing?

bndkt commented 2 years ago

Have you created the app identifier for the Clip in the Apple Developer portal according to the readme? If that's not it, could you post the logs from EAS so that I can investigate?

mariomurrent-softwaresolutions commented 2 years ago

Yes and the build is also trying to assign the correct profile

Configuring Xcode project
2
Assigning provisioning profile '*[expo] com.**** AdHoc ******' (Apple Team ID: *******) to target '*******'
3
Assigning provisioning profile '*[expo] com.*****.Clip AdHoc ******' (Apple Team ID: *******) to target '*****Clip'
4
Could not find target '*****Clip' in project.pbxproj

This is the error I'm seeing in the EAS build. I can try to build it locally. Maybe I'm getting more information there.

mariomurrent-softwaresolutions commented 2 years ago

I will need more time to make the build run locally. I'm getting different errors not related to the AppClip.

mariomurrent-softwaresolutions commented 2 years ago

Actually no idea why it is failing :(

bndkt commented 2 years ago

Ok curious. Does it build when you remove react-native-app-clip from app.json?

mariomurrent-softwaresolutions commented 2 years ago

Yes, without it EAS build is working fine - maybe I need to do a clean setup? And try out a clean setup?

mariomurrent-softwaresolutions commented 2 years ago

@bndkt One step further after upgrading all the dependencies: It is building locally. Should the iOS Folder contain a separate folder for the app clip?

bndkt commented 1 year ago

I have published a major update to this package. I'm going to close this issue for now, please open a new one if the problem appears again.