bndn / gedit-sessionsaver

The gedit session saver plugin for GNOME 3.0-3.8
GNU General Public License v2.0
14 stars 6 forks source link

Broken in Ubuntu 13.10? #2

Closed dhjw closed 10 years ago

dhjw commented 10 years ago

I'm getting errors on ubuntu 13.10 / gedit 3.8.3 / python3:

Running from terminal, on Save, I get this:

Traceback (most recent call last): File "/home/user/.local/share/gedit/plugins/sessionsaver/init.py", line 161, in on_save_session_action SaveSessionDialog(self.window, self, self.sessions).run() TypeError: new() takes 1 positional argument but 4 were given

On Manage, I get this:

Traceback (most recent call last): File "/home/user/.local/share/gedit/plugins/sessionsaver/init.py", line 164, in on_manage_sessions_action SessionManagerDialog(self, self.sessions).run() TypeError: new() takes 1 positional argument but 3 were given

...and with both, nothing ever happens in gedit.

Thanks for any advice or fix.

amandabee commented 10 years ago

I'm not seeing any errors (maybe not looking in the right place?) but nothing happens when I select "file > saved sessions > save current session"

careca1970 commented 10 years ago

Useful plugin, but... Same behavior as dhjw, on: gedit - Version 3.8.3 | Python 3.3.2 | gnome 3.8.4 | Fedora 19 Please, help. Thanks!

olehlong commented 10 years ago

I have fixed it (maybe wrong, but it works): in dialogs.py (line 54): def new(cls): replace with: def new(cls, *args):

Without it gedit 3.10.4 gives an error: plugins/sessionsaver/init.py", line 164, in on_manage_sessions_action SessionManagerDialog(self, self.sessions).run() TypeError: new() takes 1 positional argument but 3 were given

careca1970 commented 10 years ago

Change proposed by gaolong works. Thank you! Will it be updated in the project?

dhjw commented 10 years ago

Awesome, thanks! I submitted a request to merge.

bumbar1 commented 10 years ago

Seems the fix was not merged? link

Sorry to comment on closed issue, but I really love this plugin!

dhjw commented 10 years ago

The Pull Request (#3) is still open - sphax3d hasn't approved it yet. You'll have to manually apply the fix or grab the copy from my repository.

rajeshksv commented 10 years ago

The fix is working . Thanks :) Very useful plugin!

bezdelnique commented 8 years ago

Thank's to @olehlong ! :)