search

bndr / pipreqs

pipreqs - Generate pip requirements.txt file based on imports of any project. Looking for maintainers to move this project forward.
Apache License 2.0
6.38k stars 388 forks source link

scikitplot: incorrect extra requirement #218

Open bersbersbers opened 4 years ago

bersbersbers commented 4 years ago 
user@host:~> mkdir temp
user@host:~> cd temp
user@host:~/temp> echo import scikitplot > bug.py
user@host:~/temp> pipreqs 
INFO: Successfully saved requirements file in /home/bers/temp/requirements.txt
user@host:~/temp> more requirements.txt 
scikit_plot==0.3.7
scikitplot==0.1.1

The last line should not be there.

squeezer44 commented 4 years ago

@bersbersbers I just tried out your code (to clarify another question) and was not able to reproduce your effect:

user@host:~> mkdir temp
user@host:~> cd temp
user@host:~/temp> echo import scikitplot > bug.py
user@host:~/temp> pipreqs 
INFO: Successfully saved requirements file in /home/bers/temp/requirements.txt

After I opened the requirements.txt I don't see the entry you've mentioned. Only this is in: scikitplot==0.1.1

bersbersbers commented 4 years ago

@squeezer44 that is good enough as an example. I'm not sure why you don't get scikit_plot in there - either way, scikitplot is definitely incorrect. See https://pypi.org/project/scikitplot/:

A package to prevent exploit