search

bndr / pipreqs

pipreqs - Generate pip requirements.txt file based on imports of any project. Looking for maintainers to move this project forward.
Apache License 2.0
6.38k stars 388 forks source link

Fix 227 #257

Closed devashish-gaikwad closed 3 years ago

devashish-gaikwad commented 3 years ago

I have added a new feature "--trusted-host" which disables the SSL verification of the requests sent by requests.get function call.

        --trusted-host        Ignore SSL warnings, recommended using with
                              enterprise proxy.

Currently trying to fix pypy and flake8 build problems

devashish-gaikwad commented 3 years ago

Hi @alan-barzilay !

The build for Pypy seems to fail not because of the source code but because of some problem with the environment Check out this build log: https://travis-ci.org/github/bndr/pipreqs/jobs/771058058

Could not build wheels for cryptography which use PEP 517 and cannot be installed directly
The command "pip install coverage coveralls tox" failed and exited with 1 during .

What do you think ?

Possible solution ?

coveralls commented 3 years ago

Coverage Status

Coverage increased (+0.2%) to 71.542% when pulling 7e23be2d4d8dc68d67645dd6c7314e93e8e29b1d on devashish-gaikwad:ssl into 90102acdbb23c09574d27df8bd1f568d34e0cfd3 on bndr:master.

alan-barzilay commented 3 years ago

Hi @devashish-gaikwad, thank you for your PR! I will have to brush-up on SSL to understand if this is the best approach so it may take some time before I can get back to you. I would also probably need some sort of test for this PR, but to be honest I'm not sure how to implement a test involving a proxy in travis. In the mean time, you should rebase this PR onto the next branch where we are focusing development. The pypy issue is also solved there :)

Also, please squash all your commits into one

devashish-gaikwad commented 3 years ago

Hi Alan! Thanks for the advice, I'll probably close this PR and open a new one with squashed commits. ( I don't really know how to rebase a PR from one place to another, I'll also look for a travis compatible testing way for proxy