search

bndr / pipreqs

pipreqs - Generate pip requirements.txt file based on imports of any project. Looking for maintainers to move this project forward.
Apache License 2.0
6.38k stars 388 forks source link

Small change to make debugging file parse errors easier #277

Closed abrahamw88 closed 3 years ago

abrahamw88 commented 3 years ago

Now when ast.parse() encounters a file that cannot be parsed due to syntax errors it will report that filename in it's traceback.

codecov-commenter commented 3 years ago

Codecov Report

Merging #277 (4799ecb) into next (e7571ea) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             next     #277   +/-   ##
=======================================
  Coverage   87.50%   87.50%           
=======================================
  Files           2        2           
  Lines         256      256           
=======================================
  Hits          224      224           
  Misses         32       32
Impacted Files Coverage Δ
pipreqs/pipreqs.py 87.35% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e7571ea...4799ecb. Read the comment docs.

alan-barzilay commented 3 years ago

hi @abrahamw88, thank you for your contribution and welcome to pipreqs!

Now when ast.parse() encounters a file that cannot be parsed due to syntax errors it will report that filename in it's traceback.

Could you update your commit message with this? update pipreqs.py doesn´t speak much about what the commit does.