Closed EwoutH closed 10 months ago
Hi @alan-barzilay! Could you approve the CI workflows to see if they pass and review this PR?
@EwoutH for some reason the CI isnt showing for me either so I can't seem to find a way to approve it. I have been away from the project for some time while focusing on finishing my thesis so maybe I' m forgetting something obvious, sorry about that.
Looking at your pr everything seems fine so i have no problem with merging it since it is so simple, the only thing you could change is to also drop 3.6 since it is no longer supported.
Let me know if you want to change that or if you have an inkling about whats wrong with the CI, otherwise I will probably just merge the PR as is
Thanks for getting back. That's weird, it's running on my fork.
I created a separate PR for requiring Python 3.7: #339. Once that is merged I will update this PR and we will see how it goes.
implemented in #406 (except for run weekly, which we opted to not implement)
A bit of CI maintenance:
workflow_dispatch
) and once a week (Monday at 06:00 UTC)Also updates the
tox.ini
with Python 3.10 and 3.11 environments.