search

bndtools / bnd

Bnd/Bndtools. Tooling to build OSGi bundles including Eclipse, Maven, and Gradle plugins.
https://bndtools.org
Other
526 stars 304 forks source link

Update of BndEditModel #6082

Closed pkriens closed 2 months ago

pkriens commented 2 months ago

Now properly reflects the inheritance structure of Processor chains

@chrisrueger I made a few changes to your code, please verify

Signed-off-by: Peter Kriens Peter.Kriens@aQute.biz

chrisrueger commented 2 months ago

I noticed one new warning recently, but could not figure out when it came in:

image 
Description Resource    Path    Location    Type
No translation found for macro: .   bnd.bnd /bndtools.core  line 1  Bndtools Problem Marker
pkriens commented 2 months ago

I saw the warning. I could also not find it. Will investigate

pkriens commented 2 months ago

Found the warning. You added two lines to the _plugin.xml with ${.}:

            <property name="pom" type="string" description="Points to a pom.xml file. This is exclusive with revision. Can be a comma separated list of files." default="${workspace}/cnf/pom.xml" />

The ${.} is a very special macro. It is handled with included files during inclusion because we know the file location then. In the pre processing of a file with the macro processor we have no idea where we are.

We might want to think about supporting this in the -includeresource process ...

pkriens commented 2 months ago

Misunderstood the use of the ${.}. It had to be escaped and i think you do not want to have cnf in the path. ${.} refers to the directory of the preprocessed file.

chrisrueger commented 2 months ago

Misunderstood the use of the ${.}. It had to be escaped and i think you do not want to have cnf in the path. ${.} refers to the directory of the preprocessed file.

Thanks for finding this.