search

bndtools / bnd

Bnd/Bndtools. Tooling to build OSGi bundles including Eclipse, Maven, and Gradle plugins.
https://bndtools.org
Other
526 stars 304 forks source link

improve logging for connections settings files #6130

Closed chrisrueger closed 1 month ago

chrisrueger commented 1 month ago

See https://github.com/bndtools/bnd/issues/6123#issuecomment-2126543736 and https://bnd.bndtools.org/instructions/connection-settings.html

this helps to notice at least in the a logfile that HTTP Connection settings were overwritten in a connection-settings.xml or settings.xml or set via -connection-settings

this can help to save hours of painful debugging when you have forgotton about those settings.

This PR adds a log output like this:

slf4j logger

[main] INFO aQute.bnd.connection.settings.ConnectionSettings - [ConnectionSettings] Read from file: /Users/home/.bnd/connection-settings.xml (See https://bnd.bndtools.org/instructions/connection-settings.html for more information)

bnd processor.trace() system.out

[ConnectionSettings] Read from file: /Users/home/.bnd/connection-settings.xml  (See https://bnd.bndtools.org/instructions/connection-settings.html for more information)
pkriens commented 1 month ago

You know about the bnd comm command?

Anyway, good to go for me. Please merge

chrisrueger commented 1 month ago

You know about the bnd comm command?

I did not know before. I read during debugging and in the manual about the bnd command which outputs a lot of debugging information. But you have to know about the existence. Now there is a pointer in the build log output where connection settings are taken from and a link to the manual.