bndtools / bnd

Bnd/Bndtools. Tooling to build OSGi bundles including Eclipse, Maven, and Gradle plugins.
https://bndtools.org
Other
530 stars 305 forks source link

Template fragments: show Author column to make it clear when you pull in content from non-bndtools / 3rd-party #6285

Closed chrisrueger closed 1 day ago

chrisrueger commented 1 week ago

Closes https://github.com/bndtools/bnd/issues/6286

This allows a user to see where a template fragment is coming from. E.g. if the github organisation of the fragment is not "bndtools" we show "Org-name (3rd Party)" A double click on the entry opens the Github Repo of the template in the browser (e.g. https://github.com/mnlipp/de.mnl.osgi/tree/HEAD/de.mnl.osgi.bnd.repository/workspace-template).

image

A template definition like this is from an external 3rd-party author.

mnlipp/de.mnl.osgi/de.mnl.osgi.bnd.repository/workspace-template#master; \
        name=IndexedMavenRepository; \
        description="Provide an OSGi repository derived from a subset of one or more maven repositories";\

Confirmation popup

If you have selected at least one 3rd-party template, a confirmation popup shows up. We do this for security reason, because you are downloading content from a potentially untrusted source.

image

But this allows to go with the practise that 3rd-party authors can point to their master / main branch, which has the practical effect, that users always get the latest template, in case the 3rd-party author makes updates.

chrisrueger commented 6 days ago

As discussed in the call with @pkriens and @juergen-albert I will revert / discard the "snapshot" attribute idea. Instead I will do:

Based on this we decided to also allow Template authors to point to their master branch (@mnlipp )

I will work on that the next days and update the PR accordingly.

chrisrueger commented 6 days ago

@pkriens @mnlipp @juergen-albert I have pushed and updated the PR description with the latest state, based on our discussion earlier. Also adjusted the docs.

@mnlipp are you ok with your repo appearing in the screenshot?

Feedback welcome (e.g. for the Confirmation popup)

mnlipp commented 2 days ago

@mnlipp are you ok with your repo appearing in the screenshot?

Only just seen that. No problem.

chrisrueger commented 2 days ago

@pkriens how should we proceed here? I implemented all of what we discussed and decided in the call and adjusted the PR description accordingly. Just merging it and give it a try?

pkriens commented 1 day ago

Yup! Better to ask for a revert sometimes than to never fail :-)

Merge!