search

bndtools / bnd

Bnd/Bndtools. Tooling to build OSGi bundles including Eclipse, Maven, and Gradle plugins.
https://bndtools.org
Other
532 stars 305 forks source link

JarViewer: Fix orphaned temp files (remove background jobs) #6342

Closed chrisrueger closed 3 weeks ago

chrisrueger commented 3 weeks ago

Closes https://github.com/bndtools/bnd/issues/6340

this fixes all the race conditions where update methods was called multiple times by different threads and created temp folders multiple times. Now only one temp folder per opened jar is created. Also did not notice a performance problem when opening the jar.

Not sure if not using a Background Job is a good or bad to do in Eclipse. But I had the feeling they do more harm than good in this case.

chrisrueger commented 3 weeks ago

As discussed with @pkriens today, removing the Background Job should not be done. He will look into a different approach. Closing this.