search

bndtools / workspace

A starter Bnd workspace with plain OSGi dependencies and a Bnd Gradle build.
http://bndtools.org
Apache License 2.0
7 stars 13 forks source link

slight changes #12

Open juergen-albert opened 3 years ago

juergen-albert commented 3 years ago

The default workspace template we have is great to start with and also to keep up with new Versions, especially for the gradle build.

We and also a lot f our customers use it as a basic template. That said, I'd like to restructure it a bit to make it easier to reapply the template with our build-in mechanism without overwriting to many project specific settings.

My goal would be simply speaking to move all the definition of the build.bnd to separate bnd files in the ext folder. While at it, I'd like to remove the templates repo and simply point to their GAV.

When we have everything in separate files, one can simply reapply the template in bndtools and uncheck the parts I don't need or want.

bjhargrave commented 3 years ago

My goal would be simply speaking to move all the definition of the build.bnd to separate bnd files in the ext folder.

OK, sounds alright.

While at it, I'd like to remove the templates repo and simply point to their GAV.

Sure.

When we have everything in separate files, one can simply reapply the template in bndtools and uncheck the parts I don't need or want.

That sounds like a bigger change in Bndtools which will couple it to the "shape" of this repo. That will require ongoing coordination.

juergen-albert commented 3 years ago

My goal would be simply speaking to move all the definition of the build.bnd to separate bnd files in the ext folder.

OK, sounds alright.

While at it, I'd like to remove the templates repo and simply point to their GAV.

Sure.

When we have everything in separate files, one can simply reapply the template in bndtools and uncheck the parts I don't need or want.

That sounds like a bigger change in Bndtools which will couple it to the "shape" of this repo. That will require ongoing coordination.

I'm not sure what you mean. If I create a BND Workspace right now from a template like this, we already have a step in the wizard, where we can uncheck files that we don't want to apply.

bjhargrave commented 3 years ago

where we can uncheck files that we don't want to apply.

How is a user supposed to know which files to uncheck? I would think a better way would be for users to use bnd files which are not in the template repo so that they would not be overwritten by a reapplication of the template.

But it is also not clear what new template "features" a user would receive from applying the latest template. There can still be issues and the user would need to carefully review the applied changes to ensure their build is still valid.