bndtools / workspace

A starter Bnd workspace with plain OSGi dependencies and a Bnd Gradle build.
http://bndtools.org
Apache License 2.0
7 stars 13 forks source link

Added org.osgi.annotation.bundle:2.0.0 to central.maven file to satisfy issue #17 #20

Closed scottslewis closed 1 year ago

scottslewis commented 1 year ago

https://github.com/bndtools/workspace/issues/17

kriegfrj commented 1 year ago

Thanks @scottslewis! Now that I have merged #19, do you think you could rebase on master and re-push? I think then we'll be good to merge.

scottslewis commented 1 year ago

@kriegfrj I've rebased on merged #19 and now checks are passing

scottslewis commented 1 year ago

@kriegfrj @pkriens I think this is ready to merge if you please.

kriegfrj commented 1 year ago

@kriegfrj @pkriens I think this is ready to merge if you please.

Sorry @scottslewis, I had a bit of a look at it and (forgive me if I'm mistaken) it looks like you merged #19 into this PR;s branch rather than rebasing this PR onto master. Can you submit a PR, based directly on master, with only the one commit with your change? I'd like to keep the commit history clean.

scottslewis commented 1 year ago

Please see pr #21 .

@kriegfrj @pkriens two questions:

1) Can I get added on as a bndtools committer? My desire/intention is to continue to add onto the new service wizards and contributing bug reports and fixes. Doing things this way (fork) is very cumbersome.

2) I have an Eclipse plugin that is a ECF remote-services-specific enhancement (As it is now it provides some ECF-remote services dependent OSGi service wizards...for creating a grpc-based, jaxrs-based, other remote services. I would like to make distribution of this plugin as easy as possible when bndtools 7 comes out, but afaik there is not any bndtools-based plugin repo/repos/composite, etc. Any suggestions?

laeubi commented 1 year ago

I have an Eclipse plugin that is a ECF remote-services-specific enhancement (As it is now it provides some ECF-remote services dependent OSGi service wizards...for creating a grpc-based, jaxrs-based, other remote services. I would like to make distribution of this plugin as easy as possible when bndtools 7 comes out, but afaik there is not any bndtools-based plugin repo/repos/composite, etc. Any suggestions?

Usually you build a p2-site upload it somewhere (you can even deploy to maven central) and share the link with your users so the can install it with the update-software dialog of eclipse.

pkriens commented 1 year ago

@scottslewis any reason you closed it?

kriegfrj commented 1 year ago

@scottslewis any reason you closed it?

It was superseded by #21 and #22.

scottslewis commented 1 year ago

@laeubi

Usually you build a p2-site upload it somewhere (you can even deploy to maven central) and share the link with your users so the can install it with the update-software dialog of eclipse.

Yes thanks.

I've already done this (built p2-site). My question is focused on whether there is any repos/location/mktplace...whatever you want to call it...that is specifically for bndtools-dependent plugins/enhancements (and more precisely bndtools users).

I have/know I already have access to deployment via:

1) marketplace.eclipse.com (ECF project) 2) download.eclipse.org (ECF project) 3) github.com/ECF (ECF project)

However, this plugin depends specifically upon bndtools 7...to provide remote-services-specific (remote) service wizards, some distribution-provider-specific bndtools enhancements (e.g. very simple grpc protofile editor) and will eventually have more bndtools-specific remote service support.

My current path is to use some or all of 1-3 above, but since this new plugin is dependent specifically on bndtools 7 I wanted to know if there is some way to make known to bndtools users...either through mktplace or docs...I would like to use whatever is available as well. And since EF doesn't really pay much marketing attention to either ECF or Bndtools (afaict) I thought I would ask :).

pkriens commented 1 year ago

@scottslewis you closed this issue, do you still want to be a committer? I do not get any objections so I am ok

scottslewis commented 1 year ago

@pkriens yeah I'll be committer thanks.