search

bndw / wifi-card

📶 Print a QR code for connecting to your WiFi (wificard.io)
https://wificard.io
MIT License
6.58k stars 460 forks source link

Handle Query parameters #293

Open ofostier opened 1 month ago

ofostier commented 1 month ago

Regarding the request 283. I add the query parameters management.

ofostier commented 4 weeks ago

Query parameters are : ssid = string password = string encryptionMode = string WPA / WPA2-EAP / WEP eapMethod = string default 'PWD' eapIdentity = string hidePassword = string true/false hiddenSSID = string true/false portrait = string true/false additionalCards = number hideTip = string true/false lng = all available language id in translation.js file

millette commented 3 weeks ago

Perhaps it would be best to use the #hash instead of query parameters since the #hash doesn't reach the server.

Related to #283 (proper issue id links the pr accrross github).

bndw commented 3 weeks ago

@millette Good callout. I don't want this webapp to send private information to any server and query params would certainly do that. Using a hash instead is a clever workaround.

Further, I think the approach in this PR needs a little more thought. I don't love the implementation. The core logic should be factored out into a function and not jammed inline.

ofostier commented 3 weeks ago

Hi, Thanks to make me brainstorming on this I reviewed the logic and implementation