search

bnicenboim / eeguana

A package for manipulating EEG data in R.
https://bnicenboim.github.io/eeguana/
Other
21 stars 9 forks source link

Documentation for plot functions #79

Closed stonekate closed 5 years ago

stonekate commented 5 years ago

attempt 2!

bnicenboim commented 5 years ago

Hey, it looks very good!, but two things: could you use data_faces_ERP, or data_faces_10_trials for the examples. These are datasets that are available once you load the library. And see the https://cran.r-project.org/web/packages/roxygen2/vignettes/markdown.html, use back-ticks for code as in regular rmarkdown, and also do the links in rmarkdown style.

bnicenboim commented 5 years ago

great job!!!!

stonekate commented 5 years ago

oh cool, will do, thx!

On Mon, Apr 8, 2019 at 8:49 PM Bruno Nicenboim notifications@github.com wrote:

@bnicenboim commented on this pull request.

In R/plot.R https://github.com/bnicenboim/eeguana/pull/79#discussion_r273189439:

@@ -1,13 +1,28 @@ -#' Simple plot an eeg_lst object. -#' -#' This function first downsamples the egg_lst and then converts it into a long tibble. See [as_tibble.eeg_lst] for details. +#' Create a basic signal plot +#' +#' \code{plot} creates a ggplot object in which the EEG signal over the whole

you can also do plot instead of \code{plot}. I'll replace it myself, but for the next docs.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bnicenboim/eeguana/pull/79#pullrequestreview-224024187, or mute the thread https://github.com/notifications/unsubscribe-auth/AMJVQRuNHJ8w9OiFpuAEFi0FLxutqzlnks5ve48ugaJpZM4cg4vS .

-- Kate Stone PhD candidate Vasishth Lab | Department of Linguistics Potsdam University, 14467 Potsdam, Germany https://auskate.github.io