search

bnjmnp / pysoem

Cython wrapper for the Simple Open EtherCAT Master Library
MIT License
97 stars 38 forks source link

Replaced asterix import by targeted list #147

Closed RobertoRoos closed 3 months ago

RobertoRoos commented 3 months ago

This seems to already fix most of the auto-complete issues (#145 ): image

However, the doc strings aren't shown yet, which would also be expected.

bnjmnp commented 3 months ago

I liked this and so already merged it, but I'm not completely convinced of how the ec_datatype is handled. Up till now I could do this

    assert obj_0x1000.data_type == pysoem.ECT_UNSIGNED32

and now need to do this:

    assert obj_0x1000.data_type == pysoem.ec_datatype.ECT_UNSIGNED32

Which is okay in general, to not spoil the whole pysoem namespace, but this still misses auto-completion and I rather like to rename ec_datatype to just DataType.

RobertoRoos commented 2 months ago

Thanks for merging my stuff, @bnjmnp !

I liked this and so already merged it, but I'm not completely convinced of how the ec_datatype is handled.

My bad, I hadn't tested this. I see you've fixed this in c78c5ba5 by now.

...to not spoil the whole pysoem namespace...

That would be my thought. I would like to see an Enum like naming, where options are stored under a common name.
In a similar vein, it bothers me a little that all states (OP_STATE, PREOP_STATE, etc.) are difficult to find, because they don't share an enum base and they're not alphabetically grouped together.