search

bnjmnrsh-projs / signal-v-noise

Code kata using the NYT API.
https://bnjmnrsh-projs.github.io/signal-v-noise/
1 stars 0 forks source link

First load, if missing route: perpetual skeleton screen #28

Closed bnjmnrsh closed 8 months ago

bnjmnrsh commented 8 months ago

If the first load is a nonexistent slug ie

https://bnjmnrsh-projs.github.io/signal-v-noise/#tacos

The result is a perpetual skeleton screen because we are not handling the returned 404 error object from the NYT properly.

top_stories: { error: 404, error_message: "Not Found https://api.nytimes.com/svc/topstories/v2/tacos.json" }

This is currently being handled by "_fetch_articles.js".

bnjmnrsh commented 8 months ago

Appears to be resolved by e550c75, so closing for now.