It took a month longer than I thought (what doesn't?), but I'm finally done uploading all of my PMCAMx related code from Moe to the Github repo! This includes the following repositories:
If you don't have access to any of these and want it, just let me or Sebastian know and we'll give it to you asap. Now a few words about the condition of this code.
Caution! I have not re-run this code to make sure that it reproduces results. I'm confident PMCAMx-2008 will have few deviations. But, PMCAMx-PSAT and PMCAMx-UF are, in my opinion, more unstable and things could get weird.
I had a LOT of versions of this code, and I was not the best at maintaining consistency. During this github process, I tried to rectify that. For example, throughout my time at CMU, I found a good share of bugs. If I then started a new code, sometimes the bugfix made it through; sometimes I was stupid and it didn't. These should be cleared up and the recent commits should reflect this.
If there were more substantial differences, like US versus European parameters, or simplifications that were needed for the European domain but not for the US, I kept these on separate branches. We should consider merging these cleverly in the future. There is NO reason why the US code should be different than the European code! I think this is important.
I encourage everyone to take a look at the different branches, diff between them if you have time, and if you notice something weird, PLEASE raise an issue. I'm knew to this software and might have made a few mistakes.
There are lots of future directions that I think we should start on as people have time (there's not so much rush). I'll raise these in a separate issue. One might fairly ask though, "Ben, if you haven't checked the code results, and there could be mistakes, and there is more work to do before an official version is decided on, then what was the point?"
I think there were 3 points:
1) There is now a common place where you can grab the same version that I'll be using, whenever you want. As we figure out new things, we all get access to them. You can also see what other people are up to, which is nice.
2) I'm tired of only getting an end-result of other people's code. It would be nice to see at least some history there.
3) I wanted to learn how to do it. I recommend you all try it with your own codes, or these.
Hi All,
It took a month longer than I thought (what doesn't?), but I'm finally done uploading all of my PMCAMx related code from Moe to the Github repo! This includes the following repositories:
bnmurphy/PMCAMx-2008 bnmurphy/PMCAMx-UF bnmurphy/PMCAMx-PSAT SebastianArnoldt/PMCAMx-2002
If you don't have access to any of these and want it, just let me or Sebastian know and we'll give it to you asap. Now a few words about the condition of this code.
Caution! I have not re-run this code to make sure that it reproduces results. I'm confident PMCAMx-2008 will have few deviations. But, PMCAMx-PSAT and PMCAMx-UF are, in my opinion, more unstable and things could get weird.
I had a LOT of versions of this code, and I was not the best at maintaining consistency. During this github process, I tried to rectify that. For example, throughout my time at CMU, I found a good share of bugs. If I then started a new code, sometimes the bugfix made it through; sometimes I was stupid and it didn't. These should be cleared up and the recent commits should reflect this.
If there were more substantial differences, like US versus European parameters, or simplifications that were needed for the European domain but not for the US, I kept these on separate branches. We should consider merging these cleverly in the future. There is NO reason why the US code should be different than the European code! I think this is important.
I encourage everyone to take a look at the different branches, diff between them if you have time, and if you notice something weird, PLEASE raise an issue. I'm knew to this software and might have made a few mistakes.
There are lots of future directions that I think we should start on as people have time (there's not so much rush). I'll raise these in a separate issue. One might fairly ask though, "Ben, if you haven't checked the code results, and there could be mistakes, and there is more work to do before an official version is decided on, then what was the point?"
I think there were 3 points: 1) There is now a common place where you can grab the same version that I'll be using, whenever you want. As we figure out new things, we all get access to them. You can also see what other people are up to, which is nice. 2) I'm tired of only getting an end-result of other people's code. It would be nice to see at least some history there. 3) I wanted to learn how to do it. I recommend you all try it with your own codes, or these.
Cheers to you!