bnnm / wwiser

wwiser - Wwise .bnk explorer and audio simulator.
210 stars 12 forks source link

Add GitHub Actions workflow #38

Closed thethiny closed 6 months ago

thethiny commented 6 months ago

Whenever any .py file gets updated, a new release is automatically deployed. The only thing missing here is the names db3 file which you can push somewhere and have it be pulled.

bnnm commented 6 months ago

Looks good overall but may be better to update a nightly release rather than new+tag instead. Another manual job could make a new tagged/proper release instead, or I can keep doing it manually I guess.

Main reason I don't do new releases often is that testing isn't easy and wwiser wonky/complex, so new changes "work" but are kind of wip until I try some more games or encounter edge cases. Plus the userbase is minuscule so new releases for minor typos/doc feel kind of silly.

thethiny commented 6 months ago

If you prefer this to be a nightly I can work something out. It's your repo and I love CI/CD so just let me know what you prefer 👍🏻

bnnm commented 6 months ago

Thanks, I think buidling to a nightly release would be preferable since it allows me to decide when a release is "stable", plus having "numbered"/tagged releases on every commit feels kind of intimidating.

For reference in vgmstream I made a fixed release that a script updates but there is probably an easier/cleaner way to achieve that, but I didn't delve into it too much.

thethiny commented 6 months ago

@bnnm I have added 2 workflows, Nightly and Stable, and have tested both on thethiny/test_actions as nightly and stable.

Let me know if it's something you like or if you want to modify it further, or simply abort the idea altogether.

bnnm commented 6 months ago

At a glance looks good but give me some more time until I review and understand the implications.

(but basically I prefer a model like duckstation with one nightly rather than pcsx2 with many micro releases)

thethiny commented 6 months ago

but basically I prefer a model with one nightly rather than many micro releases

I've done that in which you can see here. It is one nightly tagged as latest-nightly, but whenever there's a new nightly it just renames the previous nightly to the new one, so you only end up with 1 nightly at a time.

You can also validate that by the fact that the nightly is tagged 3 days ago but the file is a few minutes ago image

At a glance looks good but give me some more time until I review and understand the implications.

Of course! Your tools have helped me and I would love to be able to help back.

bnnm commented 6 months ago

Wanted to do some local tests but guess I'll just accept this and see how it goes, can always be tweaked later.

thethiny commented 6 months ago

@bnnm I hope this can be useful to you. If you encounter any issues or behavior changes please let me know so I can update that for you 👍🏻