bnogalm / StellarQtSDK

Stellar Java SDK ported to Qt/C++. Interface to deal with Horizon API
Mozilla Public License 2.0
26 stars 12 forks source link

Update challenge transaction helpers for SEP-10 v1.3.0 #33

Open leighmcculloch opened 4 years ago

leighmcculloch commented 4 years ago

Summary

A change has been released in SEP-10 Web Authentication v1.3.0 that adds support for:

  1. Accounts not using the master key as a signer.
  2. Accounts multiple signers.

SEP-10 v1.3.0 Change: stellar/stellar-protocol@ea0d7edc3bed84a24970c5fe5fc34993e6c97e48

The new functionality requires changes to any SDK implementing challenge verification.

Details and Reference Implementations

The Stellar Go SDK is the first SDK we've implemented this new functionality and it can be used as a reference. It has implemented the following changes and similar changes may be required in this SDK:

Go SDK Change: stellar/go@8ff0848c31a940ab76f1a9177af0d9dd405ffa9b

An example of a SEP-10 server using the v1.3.0 verification process is implemented here: https://github.com/stellar/go/tree/master/exp/services/webauth

If anyone has any questions feel free to join us in #dev-discussion in stellar.public Keybase.