bnoguchi / everyauth

node.js auth package (password, facebook, & more) for Connect and Express apps
http://everyauth.com/
3.49k stars 447 forks source link

Support for Express 4.x? #462

Open goldfire opened 10 years ago

goldfire commented 10 years ago

Are there any plans to update this to support Express 4.x?

maruf89 commented 10 years ago

+1

forty4 commented 10 years ago

+1

richtera commented 10 years ago

+1

jeffgca commented 10 years ago

+1

jhonber commented 10 years ago

+1

ghost commented 10 years ago

+1

CCVonLewin commented 10 years ago

@bnoguchi, We are all very grateful for the work you have put into everyauth and we understand the difficult balance of work, life and a side project(s). Lots of developers have come to depend on this specific package and are feening to move their apps to Express 4. I understand time is probably the biggest factor but could I offer you $ to get it into your schedule? If you are already working on it, awesome, I still would contribute $ just because you deserve it. Any feedback would be super helpful.

bnoguchi commented 10 years ago

@CCVonLewin Thanks for the kick in the butt :) I started a new branch this past wknd. The new branch will support Express 4 and will also simplify some of the implementation of everyauth. I hope to finish it this weekend or by the subsequent weekend, time permitting.

bnoguchi commented 10 years ago

So I finished a first draft of a re-write of core everyauth today. See the example/ directory to get a feel for the changes. I only migrated the Facebook login module over. I need to migrate the other modules over and then clean up the re-write of core. If you'd like to help me migrate the other modules, send me a message, and I'll add you to the new https://github.com/everyauth group, where the modules will live.

I'm going to hold off on publishing to npm for now, but try this branch out in the meantime.

https://github.com/bnoguchi/everyauth/tree/0.5.x

Here's a quick summary of what's different:

If you have any questions, let me know. It's late over here, but I wanted to send an update out to this thread about the changes and upcoming new release.

inolasco commented 10 years ago

+1

If anyone wants to try the 0.5.x preview, add dependency:

"everyauth": "git://github.com/bnoguchi/everyauth.git#0.5.x"

In case you do not know already how to add github dependencies, which I didn't :P

ilanbiala commented 10 years ago

Any progress on this?

bnoguchi commented 9 years ago

There's a branch that already works for express 4.x. I'll document and push info about this tonight and re-post on this thread. ᐧ

Brian Noguchi 415.793.2122

On Fri, Nov 28, 2014 at 11:03 AM, Ilan Biala notifications@github.com wrote:

Any progress on this?

— Reply to this email directly or view it on GitHub https://github.com/bnoguchi/everyauth/issues/462#issuecomment-64921834.

tacomilkshake commented 9 years ago

I assume it's the 1.x branch? Is documentation updated in that branch for the code re-write? Thanks in advance.

ilanbiala commented 9 years ago

@bnoguchi how about getting some help from a strong contributor?

nponeccop commented 4 years ago

I'm doing something different from both 0.5.x and 1.x branches, namely I've made Google working with examples/server.js, while replacing everything deprecated, such as jade with pug and bumping express to 4.x along with other dependencies.

See also #488 for my (original) plan.

My branch is https://github.com/bnoguchi/everyauth/compare/master...nponeccop:hotfix-0.4.10

If we end with something viable, we can release it to npm in a namespace such as @foo/everyauth, and move on without any participation from @bnoguchi.