Creates content file in multilanguage setup

bnomei / kirby3-autoid

Automatic unique ID for Pages, Files and Structures including performant helpers to retrieve them. Bonus: Tiny-URL.

https://forum.getkirby.com/t/kirby3-autoid-plugin/23572

MIT License

80 stars 8 forks source link

Creates content file in multilanguage setup #22

Open mullema opened 5 years ago

mullema commented 5 years ago

Reference is this Thread

Multilanguage Setup (e.g. DE (default), EN)

Creating a page via the frontend (e.g. $page->createChild($mycontent)) while EN is current language.
Kirby creates new pages in default language only. Therefore the content file content.de.txt is created.
autoid kicks in via hook and adds the hidden field for the current language thereby creating content.en.txt (because EN is current language)

To create the content.en.txt file at that point is an unexpected side effect from the autoid plugin.

A solution could be to update only existing content files.

carstengrimm commented 5 years ago

is there a suggestion for a temporary fix? i would love testing it out with my setup.

scsskid commented 4 years ago

is this fixed?

bnomei commented 4 years ago

@scsskid thanks for reminding me again. i still have no clear idea how to achieve the suggested solution to update only existing content files in actual code.

checking if the file exist seems a bit hacky to me. as far as i can tell there are no bugs cause by having the content.en.txt file being created, right?

i am currently working on a new version of the plugin with better multilang setup. i will include this issue in testscases to solve it properly.

scsskid commented 4 years ago

I dont use your plugin currently, I just eval the issue list, since looking for sth to replace my legacy kirby2 solution, acutally I furthermore have missunderstood the issue

bnomei commented 2 years ago

might be related to an thus fixed in upcoming kirby 3.7

https://github.com/getkirby/kirby/issues/2789