bnomei / kirby3-htmlhead

Kirby Plugin for a best-practice HTML Head Element extendable with snippets
https://forum.getkirby.com/t/kirby3-htmlhead-best-practice-html-head-element-extendable-with-snippets/23585
MIT License
20 stars 0 forks source link

Skip <base> completely #24

Closed MaluNoPeleke closed 2 years ago

MaluNoPeleke commented 3 years ago

Can you please add an option to skip the addition of < base > completely? I want to add anchor links and don't need the < base > element. I tried it with null but it doesn't skip generating the line and still makes anchor links impossible.

    'htmlhead/base' => function ($kirby, $site, $page) {
      return ['href' => 'null'];
    },
bnomei commented 2 years ago

that makes sense. i will do that asap.

bnomei commented 2 years ago

lol. its much easier. you just remove that var => callback thing from the array.

   /*
    'htmlhead/base' => function ($kirby, $site, $page) {
      return ['href' => 'null'];
    },
   */
bnomei commented 2 years ago

ah. its merged. sorry... https://github.com/bnomei/kirby3-htmlhead/blob/a6f112129451dd381dc1f3c951c4ab940b94d78f/classes/HTMLHead.php#L16

bnomei commented 2 years ago

return ['href' => 'null']; or return []; should work now.