bnomei / kirby3-srcset

Kirby 3 Plugin for creating lazyloading image srcset
https://forum.getkirby.com/t/kirby-3-srcset-lazyloading-image-srcset-element/23575
MIT License
43 stars 3 forks source link

Classes are not added when using the Kirby tag #7

Closed obear closed 5 years ago

obear commented 5 years ago

When I use the kirbytag in connection with a class (srcset: 01.jpg class: w-1/2), the class is not added to the picture (or image) element.

When I use the kirbytag in connection with a class and a link (srcset: 01.jpg class: w-1/2 link: 01.jpg), the class is added to the enclosing a tag.

bnomei commented 5 years ago

thanks for reporting this issue i will fix it later today.

bnomei commented 5 years ago

i do not have the time to fully test it today. but you can use the prerelease zip if you want to until then. https://github.com/bnomei/kirby3-srcset/releases/tag/v1.4.0-alpha

bnomei commented 5 years ago

i think i used the old k2 attributes. it should work pretty much link the k3 (image: ...) now. it is not as smart with the linkattr as the (image:...) is but i do not have time to do that now.

https://getkirby.com/docs/reference/text/kirbytags/image

obear commented 5 years ago

Thanks. For me it works now! 👍