search

bnomei / kirby3-with-public-folder-kit

The Kirby 3 CMS Plainkit using Composer and a public folder Setup
13 stars 3 forks source link

Media folder in Storage/Root 🤔 #1

Closed adamkiss closed 4 years ago

adamkiss commented 4 years ago

Shouldn't be media here, and also in bnomei/kirby3-unittestkit be inside the media folder (via symlink to storage, or just there), so it's publically available? Kirby uses media folder to put generated (resized) and other stuff in, so if I don't think server (whether apache or nginx) can reach out of the public folder.

bnomei commented 4 years ago

yes. one could symlink it to the storage like i did here but i thought that would be a to much for a unittest setup.

moving the media to the storage imho only makes sense when the public folder setup is combined with automated deploys that require all non static code to be in storage folder. but thats not the case for this demo, right?

adamkiss commented 4 years ago

No no, what I mean:

root
|
|- content
|
|- …
|
|- media <-- this folder
|
|- public
|     |
|     |- media  <-- should be here, inside the /public?
|
|- storage
bnomei commented 4 years ago

sorry i messed it up with the unittestki in my head. i will check asap.

bnomei commented 4 years ago

kirby3-with-public-folder-kit is focused on automated deployments. so all non-static data in storage. public/media symlinked to storage/media

kirby3-unittestkit is just a public folder setup aka index not at root level. public/media