bnoordhuis / node-buffertools

working with node.js buffers made easy
ISC License
205 stars 35 forks source link

Breaking change in VS2013 STL #52

Closed dutch closed 10 years ago

dutch commented 10 years ago

I'm building your awesome module with VS2013, and unfortunately it fails:

error C2039: 'min' is not a member of 'std'

This seems to be due to a breaking change in the STL. Under the "Breaking Changes" section, the first item states:

Could you make this slight change wherever it needs it? Also, it would probably be nice to check the rest of the changes section to make sure nothing else is broken, but I imagine that's the only problem.

bnoordhuis commented 10 years ago

Thanks for the bug report. It's fixed in 3c521e6 and buffertools@2.0.1 has been published to npm.

dutch commented 10 years ago

Awesome, thanks!