search

bnoordhuis / node-buffertools

working with node.js buffers made easy
ISC License
205 stars 35 forks source link

pretty broken on v0.11.11 #53

Closed duralog closed 10 years ago

duralog commented 10 years ago

it has all kinds of strange compile errors (stuff to do with gid_t). I tried fixing it this morning... I was interested to see if your Buffer implementation would work in 0.11.11 ...

anyway it appears I did figure it out, and the changes aren't that hard, so I thought I'd leave you the link to the commit so you can pick up some of the easy fixes for buffer:

https://github.com/duralog/node-imagemagick-native/commit/e5e723c40f3bd40cb2e019152877f66a3e0b56b8

cheers!

bnoordhuis commented 10 years ago

"pretty broken on v0.11.11" -> "v0.11.11 is pretty broken". See joyent/node#6992, v0.11.11 is basically busted for anything involving native add-ons on UNIX platforms.

Apart from that, the V8 API changed a great deal. I'll probably switch it over to NAN when v0.12 comes out.

Thanks for opening the issue though!