search

bnoordhuis / node-buffertools

working with node.js buffers made easy
ISC License
205 stars 35 forks source link

Signed char for negative values #76

Closed skogsmaskin closed 8 years ago

skogsmaskin commented 8 years ago

Got an error compiling this unless the char was signed.

error: narrowing conversion of '-1' from 'int' to 'char'
bnoordhuis commented 8 years ago

Thanks, landed in 96bd6c2. Just curious, when are you seeing those errors? Neither g++ 5.3.1 nor clang++ 3.7.0 print that warning for me, even though -Wnarrowing is implied by -Wall -std=c++11.

skogsmaskin commented 8 years ago

I was seeing it trying to compile the module on a Raspberry Pi 2 - with latest Arch Linux ARM, Node 5.5.0 and gcc 5.3.0. It was not a warning, but an error actually.

Thank you for the merge.

daxtens commented 8 years ago

Would it be possible to publish this on npm? I'm hitting the same issue on PowerPC64 Little-Endian and would love to be able to use the npm version rather than a version from github.

bnoordhuis commented 8 years ago

@daxtens Published as buffertools@2.1.4.

daxtens commented 8 years ago

Thanks :)