search

bnoordhuis / node-iconv

node.js iconv bindings - text recoding for fun and profit!
Other
799 stars 123 forks source link

If charsets are not supported, include what they are in the error #139

Closed veselov closed 8 years ago

veselov commented 8 years ago

saves a lot on debugging

bnoordhuis commented 8 years ago

I'm fine with the change but can you add one or two regression tests? Thanks.

bnoordhuis commented 8 years ago

One final nit: can you update the commit log to 50-0-72 format? (I.e. 50 columns, blank line, one or more 72 column lines.)

veselov commented 8 years ago

Will address those. Can you please help me getting tests to run? I'm getting Error: Cannot find module '../build/Debug/iconv.node', not sure how build the "debug" version. Thank you.

bnoordhuis commented 8 years ago

Run node-gyp rebuild from the top-level directory.

veselov commented 8 years ago

Thank you. I closed this PR as I don't know how to modify pushed comment logs.