search

bnoordhuis / node-iconv

node.js iconv bindings - text recoding for fun and profit!
Other
799 stars 123 forks source link

Include charset names in error message #140

Closed veselov closed 8 years ago

veselov commented 8 years ago

Including charset names helps with debugging, avoiding to re-throw, or adding debugging statements arround.

bnoordhuis commented 8 years ago

Thanks Pawel, landed with some style fix-ups in 2760d5a.

veselov commented 8 years ago

Thank you. If there only was a language that described exactly how style should be implemented, and all (major) editors understood it...

bnoordhuis commented 8 years ago

In node.js core we use jslint, which is pretty rigorous. But as most commits in node-iconv are made by me I've never bothered to set it up. :-)

veselov commented 8 years ago

Well, I have issues with jshint, so I use jslint :) I believe jshint does want 4/8 space indentation. There is apparently this : http://jscs.info/ which at least should be solving it with JS. Unfortunately, I don't see how it can actually configure an editor (say vim) to follow the style rules, and doesn't look like I can invoke both jscs and jslint as syntastic checkers :)