bnoordhuis / node-iconv

node.js iconv bindings - text recoding for fun and profit!
Other
797 stars 123 forks source link

Build fails on node 10 because of nan version #183

Closed jehy closed 5 years ago

jehy commented 6 years ago

Error log:

../../nan/nan_maybe_43_inl.h:112:15: error: ‘class v8::Object’ has no member named ‘ForceSet’ return obj->ForceSet(isolate->GetCurrentContext(), key, value, attribs);

Ca be fixed with bumping nan dependency to latest (2.10.0).

bnoordhuis commented 6 years ago

I can update that but note that node-iconv depends on nan@^2.3.5 (note the caret.)

If npm is selecting an old version, that probably means there's something else in your dependencies that's restricting the version range.

jehy commented 6 years ago

Yeah, that's really the case! But if you update nan, then at least compile errors will be in another modules :)