search

bnoordhuis / node-iconv

node.js iconv bindings - text recoding for fun and profit!
Other
799 stars 123 forks source link

Migration to N-API #189

Open MrKashlakov opened 5 years ago

MrKashlakov commented 5 years ago

Hello! I just did migration of this module to N-API. Please review this PR. All tests passed!

mhdawson commented 5 years ago

@bnoordhuis is this something you'd be able to review/consider landing?

mhdawson commented 5 years ago

Just confirming you are waiting on responses to your comments and once they are addressed it might move forward as we are are talking about whether we need to find somebody else to take over the pr.

@MrKashlakov are you going to be able to get back to this in order to address the comments.

bnoordhuis commented 5 years ago

Just confirming you are waiting on responses to your comments and once they are addressed it might move forward

That's correct. This PR also needs a rebase now.

NickNaso commented 5 years ago

Hi @MrKashlakov I hope that you have the time to finish this work, but in case if you are busy what do you think if I help you to accomplish at tasks requested in this PR?