search

bnoordhuis / node-iconv

node.js iconv bindings - text recoding for fun and profit!
Other
799 stars 123 forks source link

First step on N-API porting #196

Open NickNaso opened 5 years ago

NickNaso commented 5 years ago

Hi everyone, I'm opening a new PR about the N-API porting because I want work on this work and I don't have write access to the previous PR (https://github.com/bnoordhuis/node-iconv/pull/189) - I tried to contact the developer that started the the porting work but I never received any answer. If possible please review this PR to move forward on ending this porting.

mhdawson commented 5 years ago

@bnoordhuis are you going to have a chance to take a look at this updated version?

mhdawson commented 5 years ago

@bnoordhuis any chance you can review again after @NickNaso rebases.

bnoordhuis commented 5 years ago

@NickNaso Sorry for the delay. Can you make sure you rebase against rather than merge in master? Your PR currently has some changes intermixed that already exist in master.

I tried to rebase it myself but there are conflicts in src/binding.cc.

NickNaso commented 5 years ago

@bnoordhuis Sorry for delay on working on this. Could you take a look and send your feedback?