search

bnoordhuis / node-iconv

node.js iconv bindings - text recoding for fun and profit!
Other
797 stars 123 forks source link

Failure on Node.js v12.0.0-pre #197

Closed BridgeAR closed 5 years ago

BridgeAR commented 5 years ago

The input validation for Buffer.alloc() is now stricter and it seems like the code passes through NaN in some cases. See https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1769/nodes=fedora-latest-x64/testReport/junit/(root)/citgm/iconv_v2_3_2/

bnoordhuis commented 5 years ago

Fixed in v2.3.3.

BridgeAR commented 5 years ago

@bnoordhuis thanks for the quick fix!